All of lore.kernel.org
 help / color / mirror / Atom feed
From: M Nikhil <nikh1092@linux.ibm.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
	linux-raid@vger.kernel.org, nvdimm@lists.linux.dev,
	linux-scsi@vger.kernel.org, hare@suse.de, hch@lst.de,
	steffen Maier <maier@linux.ibm.com>,
	Benjamin Block <bblock@linux.ibm.com>,
	Nihar Panda <niharp@linux.ibm.com>
Subject: Re: Change in reported values of some block integrity sysfs attributes
Date: Tue, 17 Dec 2024 18:09:16 +0530	[thread overview]
Message-ID: <a39d25d3-e6ac-4166-a75e-58a258da4101@linux.ibm.com> (raw)
In-Reply-To: <yq18qsjdz0r.fsf@ca-mkp.ca.oracle.com>

Thanks for the inputs Martin.

We have observed that even though the HBA does not support DIX Type, 
still the integrity attributes 'write_generate' and 'read_verify' are 
set to 1 for the block devices.


a3560030:~ # cat /sys/class/scsi_host/host0/prot_capabilities
0
a3560030:~ # cat /sys/class/scsi_host/host1/prot_capabilities
0


a3560030:~ # cat /sys/block/sdc/integrity/write_generate
1
a3560030:~ # cat /sys/block/sdc/integrity/read_verify
1


Thanks and Regards,

Nikhil

On 14/12/24 4:00 am, Martin K. Petersen wrote:
>> The sysfs attributes related to block device integrity ,
>> write_generate and read_verify are enabled for the block device when
>> the parameter device_is_integrity_capable is disabled.
> 'device_is_integrity_capable' is set if storage device (media) is
> formatted with PI.
>
> That is completely orthogonal to 'write_generate' and 'read_verify'
> which are enabled if the HBA supports DIX. If the HBA supports DIX Type
> 0, 'write_generate' and 'read_verify' are enabled even if the attached
> disk is not formatted with PI.
>
> I don't see any change in what's reported with block/for-next in a
> regular SCSI HBA/disk setup. Will have to look at whether there is a
> stacking issue wrt. multipathing.
>

  reply	other threads:[~2024-12-17 12:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  7:16 Change in reported values of some block integrity sysfs attributes M Nikhil
2024-12-13 14:33 ` Christoph Hellwig
2024-12-17 12:46   ` M Nikhil
2024-12-13 22:30 ` Martin K. Petersen
2024-12-17 12:39   ` M Nikhil [this message]
2025-02-21  6:01     ` M Nikhil
2025-02-21 10:37   ` Anuj gupta
2025-02-21 10:35     ` Anuj Gupta
2025-02-21 12:07     ` Anuj Gupta
2025-02-25  1:07       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a39d25d3-e6ac-4166-a75e-58a258da4101@linux.ibm.com \
    --to=nikh1092@linux.ibm.com \
    --cc=bblock@linux.ibm.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maier@linux.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=niharp@linux.ibm.com \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.