From: Jeff Law <jlaw@ventanamicro.com>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Alejandro Hernandez <aehs29@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Nelson Chu <nelson@rivosinc.com>
Subject: Re: [OE-core] [PATCH v2 1/3] binutils: Upgrade to 2.40 release
Date: Thu, 19 Jan 2023 10:25:32 -0700 [thread overview]
Message-ID: <a42ac89e-a844-6790-ad68-d5f7852b4e87@ventanamicro.com> (raw)
In-Reply-To: <20230119042724.1413857-1-raj.khem@gmail.com>
On 1/18/23 21:27, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v1 -> v2:
> - Fix build on mingw
> - Backport fix to build with --disable-gdb
[ ... ]
Note I think this is going to run afoul of grub2 mkimage.
In binutils-2.40 the assembler for risc-v was changed to use CALL_PLT
relocations rather than CALL relocations. grub2 does not handle
CALL_PLT relocations which in turn will cause a failure when
grub2-mkimage is used on risc-v.
As far as I can tell, the assembler change literally just changes the
relocation number, they are otherwise treated the same. So I think
grub2 can be fixed by just treating R_RISCV_CALL_PLT just like
R_RISCV_CALL in kern/riscv/dl.c.
Nelson, can you confirm that all your assembler change did was change
the relocation used in the resultant object?
Jeff
next prev parent reply other threads:[~2023-01-19 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 4:27 [PATCH v2 1/3] binutils: Upgrade to 2.40 release Khem Raj
2023-01-19 4:27 ` [PATCH v2 2/3] binutils: Package libsframe Khem Raj
2023-01-19 4:27 ` [PATCH v2 3/3] elfutils: Fix build with libcurl >= 7.87 Khem Raj
2023-01-19 9:44 ` [OE-core] [PATCH v2 1/3] binutils: Upgrade to 2.40 release Luca Ceresoli
2023-01-19 16:52 ` Khem Raj
2023-01-19 22:58 ` Luca Ceresoli
2023-01-19 23:52 ` Khem Raj
2023-01-19 17:25 ` Jeff Law [this message]
2023-01-19 18:47 ` Khem Raj
2023-01-23 23:38 ` Khem Raj
2023-01-24 4:02 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42ac89e-a844-6790-ad68-d5f7852b4e87@ventanamicro.com \
--to=jlaw@ventanamicro.com \
--cc=aehs29@gmail.com \
--cc=luca.ceresoli@bootlin.com \
--cc=nelson@rivosinc.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.