Re: [OE-core] [PATCH v2 1/3] binutils: Upgrade to 2.40 release

[Jeff Law <jlaw@ventanamicro.com>]

On 1/23/23 16:38, Khem Raj wrote:
> On Thu, Jan 19, 2023 at 9:25 AM Jeff Law <jlaw@ventanamicro.com> wrote:
>>
>>
>>
>> On 1/18/23 21:27, Khem Raj wrote:
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> v1 -> v2:
>>> - Fix build on mingw
>>> - Backport fix to build with --disable-gdb
>> [ ... ]
>> Note I think this is going to run afoul of grub2 mkimage.
>>
>> In binutils-2.40 the assembler for risc-v was changed to use CALL_PLT
>> relocations rather than CALL relocations.  grub2 does not handle
>> CALL_PLT relocations which in turn will cause a failure when
>> grub2-mkimage is used on risc-v.
>>
>> As far as I can tell, the assembler change literally just changes the
>> relocation number, they are otherwise treated the same.  So I think
>> grub2 can be fixed by just treating R_RISCV_CALL_PLT just like
>> R_RISCV_CALL in kern/riscv/dl.c.
>>
>> Nelson, can you confirm that all your assembler change did was change
>> the relocation used in the resultant object?
> 
> The binutils change is here
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=70f35d72ef04cd23771875c1661c9975044a749c
> 
> I tried something like this
> 
> http://sprunge.us/ZjpFCI
> 
> I still get
> | grub-mkimage: error: relocation 0x13 is not implemented yet.
> 
> need to look more.
That's what I would think the right fix ought to be.  Weird.

I think mkimage is run as a host tool, so I'd dig into the build of that 
on the host.

jeff