[f2fs_io] 1531853eb7: make fail

[f2fs_io] 1531853eb7: make fail

[Si, Beibei]

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

Hi Robin,



We noticed a compiling issue due to commit 1531853eb7, and its parent 3bfcca8c81 has no such compiling issue, could you pls have a check?



Commit: 1531853eb72b335c488171dd0803e9c417de7e1f (“f2fs_io: Add get file name encryption mode”)
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git master

We followed steps in /f2fs-tools/README and the output was shown as below.



/f2fs-tools# ./autogen.sh

/f2fs-tools# ./configure

/f2fs-tools# make

...

f2fs_io.h:123:28: error: field 'v1' has incomplete type

   struct fscrypt_policy_v1 v1;

                            ^~

f2fs_io.c: In function 'do_get_filename_encrypt_mode':

f2fs_io.c:1141:7: error: 'FSCRYPT_POLICY_V1' undeclared (first use in this function); did you mean 'FSCRYPT_POLICY_V2'?

  case FSCRYPT_POLICY_V1:

       ^~~~~~~~~~~~~~~~~

       FSCRYPT_POLICY_V2

f2fs_io.c:1141:7: note: each undeclared identifier is reported only once for each function it appears in

make[3]: *** [Makefile:419: f2fs_io.o] Error 1

make[3]: Leaving directory '/tmp/lkp/xfstests/src/f2fs-tools/tools/f2fs_io'

make[2]: *** [Makefile:609: all-recursive] Error 1

make[2]: Leaving directory '/tmp/lkp/xfstests/src/f2fs-tools/tools'

make[1]: *** [Makefile:421: all-recursive] Error 1

make[1]: Leaving directory '/tmp/lkp/xfstests/src/f2fs-tools'

make: *** [Makefile:353: all] Error 2





Thanks,

Carel




[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 5117 bytes --]

Re: [f2fs_io] 1531853eb7: make fail

[Jaegeuk Kim]

[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]

Hi,

I fixed this by this patch. Will update master soon.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev&id=870915f282d4666d1c4c37fc6e468682eb33d0ab

Thanks,

On Wed, May 12, 2021 at 12:30 AM Si, Beibei <beibei.si@intel.com> wrote:

> Hi Robin,
>
>
>
> We noticed a compiling issue due to commit 1531853eb7, and its parent
> 3bfcca8c81 has no such compiling issue, could you pls have a check?
>
>
>
> Commit: 1531853eb72b335c488171dd0803e9c417de7e1f (“f2fs_io: Add get file
> name encryption mode”)
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git
> master
>
>
>
> We followed steps in /f2fs-tools/README and the output was shown as below.
>
>
>
> /f2fs-tools# ./autogen.sh
>
> /f2fs-tools# ./configure
>
> /f2fs-tools# make
>
> ...
>
> f2fs_io.h:123:28: error: field 'v1' has incomplete type
>
>    struct fscrypt_policy_v1 v1;
>
>                             ^~
>
> f2fs_io.c: In function 'do_get_filename_encrypt_mode':
>
> f2fs_io.c:1141:7: error: 'FSCRYPT_POLICY_V1' undeclared (first use in this
> function); did you mean 'FSCRYPT_POLICY_V2'?
>
>   case FSCRYPT_POLICY_V1:
>
>        ^~~~~~~~~~~~~~~~~
>
>        FSCRYPT_POLICY_V2
>
> f2fs_io.c:1141:7: note: each undeclared identifier is reported only once
> for each function it appears in
>
> make[3]: *** [Makefile:419: f2fs_io.o] Error 1
>
> make[3]: Leaving directory '/tmp/lkp/xfstests/src/f2fs-tools/tools/f2fs_io'
>
> make[2]: *** [Makefile:609: all-recursive] Error 1
>
> make[2]: Leaving directory '/tmp/lkp/xfstests/src/f2fs-tools/tools'
>
> make[1]: *** [Makefile:421: all-recursive] Error 1
>
> make[1]: Leaving directory '/tmp/lkp/xfstests/src/f2fs-tools'
>
> make: *** [Makefile:353: all] Error 2
>
>
>
>
>
> Thanks,
>
> Carel
>
>
>
>
>
>
>


-- 
Jaegeuk Kim

[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 4956 bytes --]