All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCHv2 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
Date: Sun, 02 Feb 2020 10:37:30 +0530	[thread overview]
Message-ID: <a50468262ed81ca927214db39a0306a3@codeaurora.org> (raw)
In-Reply-To: <5e36535e.1c69fb81.510f6.ba36@mx.google.com>

On 2020-02-02 10:13, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2020-02-01 07:29:48)
>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml 
>> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> new file mode 100644
>> index 000000000000..5448cc537a03
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> @@ -0,0 +1,44 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
>> +
>> +maintainers:
>> +  - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> +
>> +allOf:
>> +  - $ref: watchdog.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,kpss-timer
>> +      - qcom,kpss-wdt
>> +      - qcom,kpss-wdt-apq8064
>> +      - qcom,kpss-wdt-ipq4019
>> +      - qcom,kpss-wdt-ipq8064
>> +      - qcom,kpss-wdt-msm8960
>> +      - qcom,scss-timer
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
> 
> By the way, I would expect the watchdog to have an interrupt property.
> Not sure why it isn't described in the existing binding.
> 

Yes it should be an optional property now that bark interrupt support 
has been added. I will add that in a separate patch.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCHv2 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
Date: Sun, 02 Feb 2020 10:37:30 +0530	[thread overview]
Message-ID: <a50468262ed81ca927214db39a0306a3@codeaurora.org> (raw)
In-Reply-To: <5e36535e.1c69fb81.510f6.ba36@mx.google.com>

On 2020-02-02 10:13, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2020-02-01 07:29:48)
>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml 
>> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> new file mode 100644
>> index 000000000000..5448cc537a03
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> @@ -0,0 +1,44 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
>> +
>> +maintainers:
>> +  - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> +
>> +allOf:
>> +  - $ref: watchdog.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,kpss-timer
>> +      - qcom,kpss-wdt
>> +      - qcom,kpss-wdt-apq8064
>> +      - qcom,kpss-wdt-ipq4019
>> +      - qcom,kpss-wdt-ipq8064
>> +      - qcom,kpss-wdt-msm8960
>> +      - qcom,scss-timer
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
> 
> By the way, I would expect the watchdog to have an interrupt property.
> Not sure why it isn't described in the existing binding.
> 

Yes it should be an optional property now that bark interrupt support 
has been added. I will add that in a separate patch.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-02  5:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 15:29 [PATCHv2 0/2] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2020-02-01 15:29 ` Sai Prakash Ranjan
2020-02-01 15:29 ` [PATCHv2 1/2] dt-bindings: watchdog: " Sai Prakash Ranjan
2020-02-01 15:29   ` Sai Prakash Ranjan
2020-02-02  4:41   ` Stephen Boyd
2020-02-02  4:41     ` Stephen Boyd
2020-02-02  4:43   ` Stephen Boyd
2020-02-02  4:43     ` Stephen Boyd
2020-02-02  5:07     ` Sai Prakash Ranjan [this message]
2020-02-02  5:07       ` Sai Prakash Ranjan
2020-02-06 18:39   ` Rob Herring
2020-02-06 18:39     ` Rob Herring
2020-02-01 15:29 ` [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
2020-02-01 15:29   ` Sai Prakash Ranjan
2020-02-02  4:41   ` Stephen Boyd
2020-02-02  4:41     ` Stephen Boyd
2020-02-06 18:38   ` Rob Herring
2020-02-06 18:38     ` Rob Herring
2020-02-07  6:10     ` Sai Prakash Ranjan
2020-02-07  6:10       ` Sai Prakash Ranjan
2020-02-11 18:24       ` Rob Herring
2020-02-11 18:24         ` Rob Herring
2020-02-11 21:57         ` Sai Prakash Ranjan
2020-02-11 21:57           ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a50468262ed81ca927214db39a0306a3@codeaurora.org \
    --to=saiprakash.ranjan@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.