add venus firmware file for qcs615

add venus firmware file for qcs615

[Renjiang Han (QUIC)]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Hello

The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:

  Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)

are available in the Git repository at:

  git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615

for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:

  qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)

----------------------------------------------------------------
Renjiang Han (1):
      qcom: venus-5.4: add venus firmware file for qcs615

WHENCE                      |   1 +
qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
2 files changed, 1 insertion(+)
create mode 100644 qcom/venus-5.4/venus_s6.mbn

Best Regards,
Renjiang

[-- Attachment #2: Type: text/html, Size: 4522 bytes --]

Re: add venus firmware file for qcs615

[Josh Boyer]

On Wed, Nov 13, 2024 at 5:50 AM Renjiang Han (QUIC)
<quic_renjiang@quicinc.com> wrote:
>
> Hello
>
>
>
> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>
>
>
>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>
>
>
> are available in the Git repository at:
>
>
>
>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git video-firmware-qcs615

Merged and pushed out.

https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/370

josh

>
>
>
> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>
>
>
>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>
>
>
> ----------------------------------------------------------------
>
> Renjiang Han (1):
>
>       qcom: venus-5.4: add venus firmware file for qcs615
>
>
>
> WHENCE                      |   1 +
>
> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
>
> 2 files changed, 1 insertion(+)
>
> create mode 100644 qcom/venus-5.4/venus_s6.mbn
>
>
>
> Best Regards,
>
> Renjiang

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Wed, Nov 13, 2024 at 07:22:28AM -0500, Josh Boyer wrote:
> On Wed, Nov 13, 2024 at 5:50 AM Renjiang Han (QUIC)
> <quic_renjiang@quicinc.com> wrote:
> >
> > Hello
> >
> >
> >
> > The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >
> >
> >
> >   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >
> >
> >
> > are available in the Git repository at:
> >
> >
> >
> >   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git video-firmware-qcs615
> 
> Merged and pushed out.
> 
> https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/370

Josh, it is very nice to see a promt merging of the firmware, thanks a
lot. However is there a chance that you can give reviewers a time to
react? Usually there are no issues, but I think it is important to let
the comminity to be able to review the patch / pull request.

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Josh Boyer]

On Wed, Nov 13, 2024 at 9:43 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Wed, Nov 13, 2024 at 07:22:28AM -0500, Josh Boyer wrote:
> > On Wed, Nov 13, 2024 at 5:50 AM Renjiang Han (QUIC)
> > <quic_renjiang@quicinc.com> wrote:
> > >
> > > Hello
> > >
> > >
> > >
> > > The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> > >
> > >
> > >
> > >   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> > >
> > >
> > >
> > > are available in the Git repository at:
> > >
> > >
> > >
> > >   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git video-firmware-qcs615
> >
> > Merged and pushed out.
> >
> > https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/370
>
> Josh, it is very nice to see a promt merging of the firmware, thanks a
> lot. However is there a chance that you can give reviewers a time to
> react? Usually there are no issues, but I think it is important to let
> the comminity to be able to review the patch / pull request.

Happy to let things sit for a while.  Out of curiosity, what exactly
are you reviewing?  They're binary blobs.

josh

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Wed, 13 Nov 2024 at 17:00, Josh Boyer <jwboyer@kernel.org> wrote:
>
> On Wed, Nov 13, 2024 at 9:43 AM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
> >
> > On Wed, Nov 13, 2024 at 07:22:28AM -0500, Josh Boyer wrote:
> > > On Wed, Nov 13, 2024 at 5:50 AM Renjiang Han (QUIC)
> > > <quic_renjiang@quicinc.com> wrote:
> > > >
> > > > Hello
> > > >
> > > >
> > > >
> > > > The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> > > >
> > > >
> > > >
> > > >   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> > > >
> > > >
> > > >
> > > > are available in the Git repository at:
> > > >
> > > >
> > > >
> > > >   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git video-firmware-qcs615
> > >
> > > Merged and pushed out.
> > >
> > > https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/370
> >
> > Josh, it is very nice to see a promt merging of the firmware, thanks a
> > lot. However is there a chance that you can give reviewers a time to
> > react? Usually there are no issues, but I think it is important to let
> > the comminity to be able to review the patch / pull request.
>
> Happy to let things sit for a while.  Out of curiosity, what exactly
> are you reviewing?  They're binary blobs.

Yes. However sometimes they can be pushed to a disputable location or
have other issues. In this case I'd like to understand whether this
binary is specific to QCS615 (and thus it should be a separate binary)
or it's just a somehow updated version of the existing binary.

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

Hello Josh,

On 11/13/2024 5:52 PM, Josh Boyer wrote:
> On Wed, Nov 13, 2024 at 5:50 AM Renjiang Han (QUIC)
> <quic_renjiang@quicinc.com> wrote:
>>
>> Hello
>>
>>
>>
>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>
>>
>>
>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>
>>
>>
>> are available in the Git repository at:
>>
>>
>>
>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git video-firmware-qcs615
> 
> Merged and pushed out.
With this, we have now 2 binaries in qcom/venus-5.4 folder, namely venus.mbn and
venus_s6.mbn. There are no active client using venus_s6.mbn at the moment, and
it was added to support video usecase on qcs615. It seems like qcs615 can use
venus.mbn itself and we do not need separate bin. Let me know if you are good to
delete venus_s6.mbn, given that there are no active client using it. If you are
ok, we will raise a PR to delete it and update venus.mbn. You can find the more
discussion here [1] on the same.

[1]
https://lore.kernel.org/all/ng4o7sdejoh4jn4nnarjd4lio4lbx2tiuiz5c6bigjbtxldinr@xl5wx6dmdivy/T/

Regards,
Vikash
> 
> https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/370
> 
> josh
> 
>>
>>
>>
>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>
>>
>>
>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>
>>
>>
>> ----------------------------------------------------------------
>>
>> Renjiang Han (1):
>>
>>       qcom: venus-5.4: add venus firmware file for qcs615
>>
>>
>>
>> WHENCE                      |   1 +
>>
>> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
>>
>> 2 files changed, 1 insertion(+)
>>
>> create mode 100644 qcom/venus-5.4/venus_s6.mbn
>>
>>
>>
>> Best Regards,
>>
>> Renjiang

Re: add venus firmware file for qcs615

[Josh Boyer]

On Thu, Dec 12, 2024 at 4:23 AM Vikash Garodia
<quic_vgarodia@quicinc.com> wrote:
>
> Hello Josh,
>
> On 11/13/2024 5:52 PM, Josh Boyer wrote:
> > On Wed, Nov 13, 2024 at 5:50 AM Renjiang Han (QUIC)
> > <quic_renjiang@quicinc.com> wrote:
> >>
> >> Hello
> >>
> >>
> >>
> >> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>
> >>
> >>
> >>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>
> >>
> >>
> >> are available in the Git repository at:
> >>
> >>
> >>
> >>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git video-firmware-qcs615
> >
> > Merged and pushed out.
> With this, we have now 2 binaries in qcom/venus-5.4 folder, namely venus.mbn and
> venus_s6.mbn. There are no active client using venus_s6.mbn at the moment, and
> it was added to support video usecase on qcs615. It seems like qcs615 can use
> venus.mbn itself and we do not need separate bin. Let me know if you are good to
> delete venus_s6.mbn, given that there are no active client using it. If you are
> ok, we will raise a PR to delete it and update venus.mbn. You can find the more
> discussion here [1] on the same.

Seems fine, but you likely want to include a symlink for venus_sb6.mbn
as Dmitry suggested.

josh

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> Hello
> 
> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> 
>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> 
> are available in the Git repository at:
> 
>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> 
> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> 
>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> 
> ----------------------------------------------------------------
> Renjiang Han (1):
>       qcom: venus-5.4: add venus firmware file for qcs615
> 
> WHENCE                      |   1 +

Could you please be more specific, what is the difference between the
existing file and a new file? According to the soc_vers the new file
supports sdm845. Should it instead replace the old firmware?

> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
> 2 files changed, 1 insertion(+)
> create mode 100644 qcom/venus-5.4/venus_s6.mbn
> 
> Best Regards,
> Renjiang

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>> Hello
>>
>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>
>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>
>> are available in the Git repository at:
>>
>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>
>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>
>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>
>> ----------------------------------------------------------------
>> Renjiang Han (1):
>>       qcom: venus-5.4: add venus firmware file for qcs615
>>
>> WHENCE                      |   1 +
> 
> Could you please be more specific, what is the difference between the
> existing file and a new file? According to the soc_vers the new file
> supports sdm845. Should it instead replace the old firmware?
SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
different signing for qcs615, it takes a separate bin (xxx_s6.mbn).

Regards,
Vikash
> 
>> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
>> 2 files changed, 1 insertion(+)
>> create mode 100644 qcom/venus-5.4/venus_s6.mbn
>>
>> Best Regards,
>> Renjiang
> 

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> 
> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> > On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >> Hello
> >>
> >> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>
> >>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>
> >> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>
> >>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>
> >> ----------------------------------------------------------------
> >> Renjiang Han (1):
> >>       qcom: venus-5.4: add venus firmware file for qcs615
> >>
> >> WHENCE                      |   1 +
> > 
> > Could you please be more specific, what is the difference between the
> > existing file and a new file? According to the soc_vers the new file
> > supports sdm845. Should it instead replace the old firmware?
> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).

Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
use v5 signatures?

> 
> Regards,
> Vikash
> > 
> >> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
> >> 2 files changed, 1 insertion(+)
> >> create mode 100644 qcom/venus-5.4/venus_s6.mbn
> >>
> >> Best Regards,
> >> Renjiang
> > 

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
>>
>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>>>> Hello
>>>>
>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>>>
>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>>>
>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>>>
>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>>>
>>>> ----------------------------------------------------------------
>>>> Renjiang Han (1):
>>>>       qcom: venus-5.4: add venus firmware file for qcs615
>>>>
>>>> WHENCE                      |   1 +
>>>
>>> Could you please be more specific, what is the difference between the
>>> existing file and a new file? According to the soc_vers the new file
>>> supports sdm845. Should it instead replace the old firmware?
>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> 
> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> use v5 signatures?
Infact we started with loading sc7180 firmware on qc615, video init failed. So
far i have seen 2 categories in signing version for video bins, either default
or v6 specific tool.

Regards,
Vikash
> 
>>
>> Regards,
>> Vikash
>>>
>>>> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
>>>> 2 files changed, 1 insertion(+)
>>>> create mode 100644 qcom/venus-5.4/venus_s6.mbn
>>>>
>>>> Best Regards,
>>>> Renjiang
>>>
> 

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>
>
> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> > On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> >>
> >> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> >>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >>>> Hello
> >>>>
> >>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>>>
> >>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>>>
> >>>> are available in the Git repository at:
> >>>>
> >>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>>>
> >>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>>>
> >>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>>>
> >>>> ----------------------------------------------------------------
> >>>> Renjiang Han (1):
> >>>>       qcom: venus-5.4: add venus firmware file for qcs615
> >>>>
> >>>> WHENCE                      |   1 +
> >>>
> >>> Could you please be more specific, what is the difference between the
> >>> existing file and a new file? According to the soc_vers the new file
> >>> supports sdm845. Should it instead replace the old firmware?
> >> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> >> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> >
> > Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> > use v5 signatures?
> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> far i have seen 2 categories in signing version for video bins, either default
> or v6 specific tool.

Can firmware / security engineers actually advice us on using v5
firmware signatures with QCS615 _and_ with older platforms?
Existing venus-5.4/venus.mbn uses v3

>
> Regards,
> Vikash
> >
> >>
> >> Regards,
> >> Vikash
> >>>
> >>>> qcom/venus-5.4/venus_s6.mbn | Bin 0 -> 922240 bytes
> >>>> 2 files changed, 1 insertion(+)
> >>>> create mode 100644 qcom/venus-5.4/venus_s6.mbn
> >>>>
> >>>> Best Regards,
> >>>> Renjiang
> >>>
> >



-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> >
> >
> > On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> > > On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> > >>
> > >> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> > >>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> > >>>> Hello
> > >>>>
> > >>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> > >>>>
> > >>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> > >>>>
> > >>>> are available in the Git repository at:
> > >>>>
> > >>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> > >>>>
> > >>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> > >>>>
> > >>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> > >>>>
> > >>>> ----------------------------------------------------------------
> > >>>> Renjiang Han (1):
> > >>>>       qcom: venus-5.4: add venus firmware file for qcs615
> > >>>>
> > >>>> WHENCE                      |   1 +
> > >>>
> > >>> Could you please be more specific, what is the difference between the
> > >>> existing file and a new file? According to the soc_vers the new file
> > >>> supports sdm845. Should it instead replace the old firmware?
> > >> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> > >> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> > >
> > > Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> > > use v5 signatures?
> > Infact we started with loading sc7180 firmware on qc615, video init failed. So
> > far i have seen 2 categories in signing version for video bins, either default
> > or v6 specific tool.
> 
> Can firmware / security engineers actually advice us on using v5
> firmware signatures with QCS615 _and_ with older platforms?
> Existing venus-5.4/venus.mbn uses v3

Vikash, any updates on this topic? Would it be possible to have a single
FW image with just v5 signatures?

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>>>
>>>
>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
>>>>>
>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>>>>>>> Hello
>>>>>>>
>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>>>>>>
>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>>>>>>
>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>>>>>>
>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>>>>>>
>>>>>>> ----------------------------------------------------------------
>>>>>>> Renjiang Han (1):
>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
>>>>>>>
>>>>>>> WHENCE                      |   1 +
>>>>>>
>>>>>> Could you please be more specific, what is the difference between the
>>>>>> existing file and a new file? According to the soc_vers the new file
>>>>>> supports sdm845. Should it instead replace the old firmware?
>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
>>>>
>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
>>>> use v5 signatures?
>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
>>> far i have seen 2 categories in signing version for video bins, either default
>>> or v6 specific tool.
>>
>> Can firmware / security engineers actually advice us on using v5
>> firmware signatures with QCS615 _and_ with older platforms?
>> Existing venus-5.4/venus.mbn uses v3
> 
> Vikash, any updates on this topic? Would it be possible to have a single
> FW image with just v5 signatures?
Not yet Dmitry. Having a followup with relevant folks this friday to understand
the signing requirements across different SOCs, hopefully will be able to add
something on this by then.
Regards,
Vikash

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
> 
> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> > On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> >> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> >>>
> >>>
> >>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> >>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> >>>>>
> >>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> >>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >>>>>>> Hello
> >>>>>>>
> >>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>>>>>>
> >>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>>>>>>
> >>>>>>> are available in the Git repository at:
> >>>>>>>
> >>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>>>>>>
> >>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>>>>>>
> >>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>>>>>>
> >>>>>>> ----------------------------------------------------------------
> >>>>>>> Renjiang Han (1):
> >>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
> >>>>>>>
> >>>>>>> WHENCE                      |   1 +
> >>>>>>
> >>>>>> Could you please be more specific, what is the difference between the
> >>>>>> existing file and a new file? According to the soc_vers the new file
> >>>>>> supports sdm845. Should it instead replace the old firmware?
> >>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> >>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> >>>>
> >>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> >>>> use v5 signatures?
> >>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> >>> far i have seen 2 categories in signing version for video bins, either default
> >>> or v6 specific tool.
> >>
> >> Can firmware / security engineers actually advice us on using v5
> >> firmware signatures with QCS615 _and_ with older platforms?
> >> Existing venus-5.4/venus.mbn uses v3
> > 
> > Vikash, any updates on this topic? Would it be possible to have a single
> > FW image with just v5 signatures?
> Not yet Dmitry. Having a followup with relevant folks this friday to understand
> the signing requirements across different SOCs, hopefully will be able to add
> something on this by then.

Ack, thank you.

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
> > 
> > On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> > > On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> > >> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> > >>>
> > >>>
> > >>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> > >>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> > >>>>>
> > >>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> > >>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> > >>>>>>> Hello
> > >>>>>>>
> > >>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> > >>>>>>>
> > >>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> > >>>>>>>
> > >>>>>>> are available in the Git repository at:
> > >>>>>>>
> > >>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> > >>>>>>>
> > >>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> > >>>>>>>
> > >>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> > >>>>>>>
> > >>>>>>> ----------------------------------------------------------------
> > >>>>>>> Renjiang Han (1):
> > >>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
> > >>>>>>>
> > >>>>>>> WHENCE                      |   1 +
> > >>>>>>
> > >>>>>> Could you please be more specific, what is the difference between the
> > >>>>>> existing file and a new file? According to the soc_vers the new file
> > >>>>>> supports sdm845. Should it instead replace the old firmware?
> > >>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> > >>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> > >>>>
> > >>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> > >>>> use v5 signatures?
> > >>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> > >>> far i have seen 2 categories in signing version for video bins, either default
> > >>> or v6 specific tool.
> > >>
> > >> Can firmware / security engineers actually advice us on using v5
> > >> firmware signatures with QCS615 _and_ with older platforms?
> > >> Existing venus-5.4/venus.mbn uses v3
> > > 
> > > Vikash, any updates on this topic? Would it be possible to have a single
> > > FW image with just v5 signatures?
> > Not yet Dmitry. Having a followup with relevant folks this friday to understand
> > the signing requirements across different SOCs, hopefully will be able to add
> > something on this by then.

It's been more than a week since the last email. Are there any updates?
I'd really like to get this sorted out before next linux-firmware
release, otherwise we'll be stuck with these names for the foreseeable
future.

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

Hi Dmitry,

On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
>>>
>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
>>>>>>>>
>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>>>>>>>>>> Hello
>>>>>>>>>>
>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>>>>>>>>>
>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>>>>>>>>>
>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>
>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>>>>>>>>>
>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>>>>>>>>>
>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>>>>>>>>>
>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>> Renjiang Han (1):
>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
>>>>>>>>>>
>>>>>>>>>> WHENCE                      |   1 +
>>>>>>>>>
>>>>>>>>> Could you please be more specific, what is the difference between the
>>>>>>>>> existing file and a new file? According to the soc_vers the new file
>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
>>>>>>>
>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
>>>>>>> use v5 signatures?
>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
>>>>>> far i have seen 2 categories in signing version for video bins, either default
>>>>>> or v6 specific tool.
>>>>>
>>>>> Can firmware / security engineers actually advice us on using v5
>>>>> firmware signatures with QCS615 _and_ with older platforms?
>>>>> Existing venus-5.4/venus.mbn uses v3
>>>>
>>>> Vikash, any updates on this topic? Would it be possible to have a single
>>>> FW image with just v5 signatures?
>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
>>> the signing requirements across different SOCs, hopefully will be able to add
>>> something on this by then.
> 
> It's been more than a week since the last email. Are there any updates?
> I'd really like to get this sorted out before next linux-firmware
> release, otherwise we'll be stuck with these names for the foreseeable
> future.
I have been chasing both the firmware and security folks to align on this. So
far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
to different set of binaries. These MBN versions of signing is defined at SOC
level and depends on secure boot libraries used in that SOC.
At the same time, there is an experiment to check if SC7180 can be signed with
version used for QCS615 i.e MBNV6.
One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
is not enabled yet (patches in review) for video, we should be good if we
conclude the firmware part before accepting the qcs615 enablement patches ?

Regards
Vikash

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
> Hi Dmitry,
> 
> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
> > On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
> >> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
> >>>
> >>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> >>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> >>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> >>>>>>
> >>>>>>
> >>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> >>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> >>>>>>>>
> >>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> >>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >>>>>>>>>> Hello
> >>>>>>>>>>
> >>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>>>>>>>>>
> >>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>>>>>>>>>
> >>>>>>>>>> are available in the Git repository at:
> >>>>>>>>>>
> >>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>>>>>>>>>
> >>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>>>>>>>>>
> >>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>>>>>>>>>
> >>>>>>>>>> ----------------------------------------------------------------
> >>>>>>>>>> Renjiang Han (1):
> >>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
> >>>>>>>>>>
> >>>>>>>>>> WHENCE                      |   1 +
> >>>>>>>>>
> >>>>>>>>> Could you please be more specific, what is the difference between the
> >>>>>>>>> existing file and a new file? According to the soc_vers the new file
> >>>>>>>>> supports sdm845. Should it instead replace the old firmware?
> >>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> >>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> >>>>>>>
> >>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> >>>>>>> use v5 signatures?
> >>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> >>>>>> far i have seen 2 categories in signing version for video bins, either default
> >>>>>> or v6 specific tool.
> >>>>>
> >>>>> Can firmware / security engineers actually advice us on using v5
> >>>>> firmware signatures with QCS615 _and_ with older platforms?
> >>>>> Existing venus-5.4/venus.mbn uses v3
> >>>>
> >>>> Vikash, any updates on this topic? Would it be possible to have a single
> >>>> FW image with just v5 signatures?
> >>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
> >>> the signing requirements across different SOCs, hopefully will be able to add
> >>> something on this by then.
> > 
> > It's been more than a week since the last email. Are there any updates?
> > I'd really like to get this sorted out before next linux-firmware
> > release, otherwise we'll be stuck with these names for the foreseeable
> > future.
> I have been chasing both the firmware and security folks to align on this. So
> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading

I think the existing firmware uses v3, not v5.

00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|


> to different set of binaries. These MBN versions of signing is defined at SOC
> level and depends on secure boot libraries used in that SOC.
> At the same time, there is an experiment to check if SC7180 can be signed with
> version used for QCS615 i.e MBNV6.

Thanks! Are you trying that without updating the whole bootloader stack? I
think some of SC7180 devices might be EOL'd, so it might be hard to get
FW/bootloader updates.

> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
> is not enabled yet (patches in review) for video, we should be good if we
> conclude the firmware part before accepting the qcs615 enablement patches ?

Good question. I think that depends on linux-firmware maintainer's
opinion.

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

On 12/2/2024 6:16 PM, Dmitry Baryshkov wrote:
> On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
>> Hi Dmitry,
>>
>> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
>>> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
>>>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
>>>>>
>>>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
>>>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
>>>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
>>>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
>>>>>>>>>>
>>>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
>>>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>>>>>>>>>>>> Hello
>>>>>>>>>>>>
>>>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>>>>>>>>>>>
>>>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>>>>>>>>>>>
>>>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>>>
>>>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>>>>>>>>>>>
>>>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>>>>>>>>>>>
>>>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>>>>>>>>>>>
>>>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>>>> Renjiang Han (1):
>>>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
>>>>>>>>>>>>
>>>>>>>>>>>> WHENCE                      |   1 +
>>>>>>>>>>>
>>>>>>>>>>> Could you please be more specific, what is the difference between the
>>>>>>>>>>> existing file and a new file? According to the soc_vers the new file
>>>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
>>>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
>>>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
>>>>>>>>>
>>>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
>>>>>>>>> use v5 signatures?
>>>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
>>>>>>>> far i have seen 2 categories in signing version for video bins, either default
>>>>>>>> or v6 specific tool.
>>>>>>>
>>>>>>> Can firmware / security engineers actually advice us on using v5
>>>>>>> firmware signatures with QCS615 _and_ with older platforms?
>>>>>>> Existing venus-5.4/venus.mbn uses v3
>>>>>>
>>>>>> Vikash, any updates on this topic? Would it be possible to have a single
>>>>>> FW image with just v5 signatures?
>>>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
>>>>> the signing requirements across different SOCs, hopefully will be able to add
>>>>> something on this by then.
>>>
>>> It's been more than a week since the last email. Are there any updates?
>>> I'd really like to get this sorted out before next linux-firmware
>>> release, otherwise we'll be stuck with these names for the foreseeable
>>> future.
>> I have been chasing both the firmware and security folks to align on this. So
>> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
> 
> I think the existing firmware uses v3, not v5.
> 
> 00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|
> 
> 
>> to different set of binaries. These MBN versions of signing is defined at SOC
>> level and depends on secure boot libraries used in that SOC.
>> At the same time, there is an experiment to check if SC7180 can be signed with
>> version used for QCS615 i.e MBNV6.
> 
> Thanks! Are you trying that without updating the whole bootloader stack? I
> think some of SC7180 devices might be EOL'd, so it might be hard to get
> FW/bootloader updates.
Just the firmware part, by signing it with qcs615 way, as an experiment
suggested by security folks.

>> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
>> is not enabled yet (patches in review) for video, we should be good if we
>> conclude the firmware part before accepting the qcs615 enablement patches ?
> 
> Good question. I think that depends on linux-firmware maintainer's
> opinion.
> 

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Mon, Dec 02, 2024 at 06:20:40PM +0530, Vikash Garodia wrote:
> 
> On 12/2/2024 6:16 PM, Dmitry Baryshkov wrote:
> > On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
> >> Hi Dmitry,
> >>
> >> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
> >>> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
> >>>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
> >>>>>
> >>>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> >>>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> >>>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> >>>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> >>>>>>>>>>
> >>>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> >>>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >>>>>>>>>>>> Hello
> >>>>>>>>>>>>
> >>>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>>>>>>>>>>>
> >>>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>>>>>>>>>>>
> >>>>>>>>>>>> are available in the Git repository at:
> >>>>>>>>>>>>
> >>>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>>>>>>>>>>>
> >>>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>>>>>>>>>>>
> >>>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>>>>>>>>>>>
> >>>>>>>>>>>> ----------------------------------------------------------------
> >>>>>>>>>>>> Renjiang Han (1):
> >>>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
> >>>>>>>>>>>>
> >>>>>>>>>>>> WHENCE                      |   1 +
> >>>>>>>>>>>
> >>>>>>>>>>> Could you please be more specific, what is the difference between the
> >>>>>>>>>>> existing file and a new file? According to the soc_vers the new file
> >>>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
> >>>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> >>>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> >>>>>>>>>
> >>>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> >>>>>>>>> use v5 signatures?
> >>>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> >>>>>>>> far i have seen 2 categories in signing version for video bins, either default
> >>>>>>>> or v6 specific tool.
> >>>>>>>
> >>>>>>> Can firmware / security engineers actually advice us on using v5
> >>>>>>> firmware signatures with QCS615 _and_ with older platforms?
> >>>>>>> Existing venus-5.4/venus.mbn uses v3
> >>>>>>
> >>>>>> Vikash, any updates on this topic? Would it be possible to have a single
> >>>>>> FW image with just v5 signatures?
> >>>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
> >>>>> the signing requirements across different SOCs, hopefully will be able to add
> >>>>> something on this by then.
> >>>
> >>> It's been more than a week since the last email. Are there any updates?
> >>> I'd really like to get this sorted out before next linux-firmware
> >>> release, otherwise we'll be stuck with these names for the foreseeable
> >>> future.
> >> I have been chasing both the firmware and security folks to align on this. So
> >> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
> > 
> > I think the existing firmware uses v3, not v5.
> > 
> > 00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|
> > 
> > 
> >> to different set of binaries. These MBN versions of signing is defined at SOC
> >> level and depends on secure boot libraries used in that SOC.
> >> At the same time, there is an experiment to check if SC7180 can be signed with
> >> version used for QCS615 i.e MBNV6.
> > 
> > Thanks! Are you trying that without updating the whole bootloader stack? I
> > think some of SC7180 devices might be EOL'd, so it might be hard to get
> > FW/bootloader updates.
> Just the firmware part, by signing it with qcs615 way, as an experiment
> suggested by security folks.

Ok, that doesn't sound like a lengthy experiment: resign the FW, boot
the laptop, caboom or not caboom. If I remember correctly the file that
you've pushed even lists sc7180 as allowed.

> 
> >> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
> >> is not enabled yet (patches in review) for video, we should be good if we
> >> conclude the firmware part before accepting the qcs615 enablement patches ?
> > 
> > Good question. I think that depends on linux-firmware maintainer's
> > opinion.
> > 

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

On 12/2/2024 8:41 PM, Dmitry Baryshkov wrote:
> On Mon, Dec 02, 2024 at 06:20:40PM +0530, Vikash Garodia wrote:
>>
>> On 12/2/2024 6:16 PM, Dmitry Baryshkov wrote:
>>> On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
>>>> Hi Dmitry,
>>>>
>>>> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
>>>>> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
>>>>>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
>>>>>>>
>>>>>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
>>>>>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
>>>>>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
>>>>>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
>>>>>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>>>>>>>>>>>>>> Hello
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>>>>>> Renjiang Han (1):
>>>>>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> WHENCE                      |   1 +
>>>>>>>>>>>>>
>>>>>>>>>>>>> Could you please be more specific, what is the difference between the
>>>>>>>>>>>>> existing file and a new file? According to the soc_vers the new file
>>>>>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
>>>>>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
>>>>>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
>>>>>>>>>>>
>>>>>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
>>>>>>>>>>> use v5 signatures?
>>>>>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
>>>>>>>>>> far i have seen 2 categories in signing version for video bins, either default
>>>>>>>>>> or v6 specific tool.
>>>>>>>>>
>>>>>>>>> Can firmware / security engineers actually advice us on using v5
>>>>>>>>> firmware signatures with QCS615 _and_ with older platforms?
>>>>>>>>> Existing venus-5.4/venus.mbn uses v3
>>>>>>>>
>>>>>>>> Vikash, any updates on this topic? Would it be possible to have a single
>>>>>>>> FW image with just v5 signatures?
>>>>>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
>>>>>>> the signing requirements across different SOCs, hopefully will be able to add
>>>>>>> something on this by then.
>>>>>
>>>>> It's been more than a week since the last email. Are there any updates?
>>>>> I'd really like to get this sorted out before next linux-firmware
>>>>> release, otherwise we'll be stuck with these names for the foreseeable
>>>>> future.
>>>> I have been chasing both the firmware and security folks to align on this. So
>>>> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
>>>
>>> I think the existing firmware uses v3, not v5.
>>>
>>> 00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|
>>>
>>>
>>>> to different set of binaries. These MBN versions of signing is defined at SOC
>>>> level and depends on secure boot libraries used in that SOC.
>>>> At the same time, there is an experiment to check if SC7180 can be signed with
>>>> version used for QCS615 i.e MBNV6.
>>>
>>> Thanks! Are you trying that without updating the whole bootloader stack? I
>>> think some of SC7180 devices might be EOL'd, so it might be hard to get
>>> FW/bootloader updates.
>> Just the firmware part, by signing it with qcs615 way, as an experiment
>> suggested by security folks.
> 
> Ok, that doesn't sound like a lengthy experiment: resign the FW, boot
> the laptop, caboom or not caboom. If I remember correctly the file that
> you've pushed even lists sc7180 as allowed.
its used only for qcs615.
> 
>>
>>>> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
>>>> is not enabled yet (patches in review) for video, we should be good if we
>>>> conclude the firmware part before accepting the qcs615 enablement patches ?
>>>
>>> Good question. I think that depends on linux-firmware maintainer's
>>> opinion.
>>>
> 

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Mon, Dec 02, 2024 at 08:51:15PM +0530, Vikash Garodia wrote:
> 
> On 12/2/2024 8:41 PM, Dmitry Baryshkov wrote:
> > On Mon, Dec 02, 2024 at 06:20:40PM +0530, Vikash Garodia wrote:
> >>
> >> On 12/2/2024 6:16 PM, Dmitry Baryshkov wrote:
> >>> On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
> >>>> Hi Dmitry,
> >>>>
> >>>> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
> >>>>> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
> >>>>>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
> >>>>>>>
> >>>>>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> >>>>>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> >>>>>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> >>>>>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> >>>>>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >>>>>>>>>>>>>> Hello
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> are available in the Git repository at:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> ----------------------------------------------------------------
> >>>>>>>>>>>>>> Renjiang Han (1):
> >>>>>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> WHENCE                      |   1 +
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Could you please be more specific, what is the difference between the
> >>>>>>>>>>>>> existing file and a new file? According to the soc_vers the new file
> >>>>>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
> >>>>>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> >>>>>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> >>>>>>>>>>>
> >>>>>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> >>>>>>>>>>> use v5 signatures?
> >>>>>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> >>>>>>>>>> far i have seen 2 categories in signing version for video bins, either default
> >>>>>>>>>> or v6 specific tool.
> >>>>>>>>>
> >>>>>>>>> Can firmware / security engineers actually advice us on using v5
> >>>>>>>>> firmware signatures with QCS615 _and_ with older platforms?
> >>>>>>>>> Existing venus-5.4/venus.mbn uses v3
> >>>>>>>>
> >>>>>>>> Vikash, any updates on this topic? Would it be possible to have a single
> >>>>>>>> FW image with just v5 signatures?
> >>>>>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
> >>>>>>> the signing requirements across different SOCs, hopefully will be able to add
> >>>>>>> something on this by then.
> >>>>>
> >>>>> It's been more than a week since the last email. Are there any updates?
> >>>>> I'd really like to get this sorted out before next linux-firmware
> >>>>> release, otherwise we'll be stuck with these names for the foreseeable
> >>>>> future.
> >>>> I have been chasing both the firmware and security folks to align on this. So
> >>>> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
> >>>
> >>> I think the existing firmware uses v3, not v5.
> >>>
> >>> 00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|
> >>>
> >>>
> >>>> to different set of binaries. These MBN versions of signing is defined at SOC
> >>>> level and depends on secure boot libraries used in that SOC.
> >>>> At the same time, there is an experiment to check if SC7180 can be signed with
> >>>> version used for QCS615 i.e MBNV6.
> >>>
> >>> Thanks! Are you trying that without updating the whole bootloader stack? I
> >>> think some of SC7180 devices might be EOL'd, so it might be hard to get
> >>> FW/bootloader updates.
> >> Just the firmware part, by signing it with qcs615 way, as an experiment
> >> suggested by security folks.
> > 
> > Ok, that doesn't sound like a lengthy experiment: resign the FW, boot
> > the laptop, caboom or not caboom. If I remember correctly the file that
> > you've pushed even lists sc7180 as allowed.
> its used only for qcs615.

Huh? venus_s6.mbn lists 0x6000, 0x6001, 0x6004, 0x6005, 0x6007, 0x9001
and 0x600E as soc_vers values. I think that includes sc7180.

> >>>> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
> >>>> is not enabled yet (patches in review) for video, we should be good if we
> >>>> conclude the firmware part before accepting the qcs615 enablement patches ?
> >>>
> >>> Good question. I think that depends on linux-firmware maintainer's
> >>> opinion.
> >>>
> > 

-- 
With best wishes
Dmitry

Re: add venus firmware file for qcs615

[Vikash Garodia]

On 12/2/2024 8:51 PM, Vikash Garodia wrote:
> 
> On 12/2/2024 8:41 PM, Dmitry Baryshkov wrote:
>> On Mon, Dec 02, 2024 at 06:20:40PM +0530, Vikash Garodia wrote:
>>>
>>> On 12/2/2024 6:16 PM, Dmitry Baryshkov wrote:
>>>> On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
>>>>> Hi Dmitry,
>>>>>
>>>>> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
>>>>>> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
>>>>>>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
>>>>>>>>
>>>>>>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
>>>>>>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
>>>>>>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
>>>>>>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
>>>>>>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
>>>>>>>>>>>>>>> Hello
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>>>>>>> Renjiang Han (1):
>>>>>>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> WHENCE                      |   1 +
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Could you please be more specific, what is the difference between the
>>>>>>>>>>>>>> existing file and a new file? According to the soc_vers the new file
>>>>>>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
>>>>>>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
>>>>>>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
>>>>>>>>>>>>
>>>>>>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
>>>>>>>>>>>> use v5 signatures?
>>>>>>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
>>>>>>>>>>> far i have seen 2 categories in signing version for video bins, either default
>>>>>>>>>>> or v6 specific tool.
>>>>>>>>>>
>>>>>>>>>> Can firmware / security engineers actually advice us on using v5
>>>>>>>>>> firmware signatures with QCS615 _and_ with older platforms?
>>>>>>>>>> Existing venus-5.4/venus.mbn uses v3
>>>>>>>>>
>>>>>>>>> Vikash, any updates on this topic? Would it be possible to have a single
>>>>>>>>> FW image with just v5 signatures?
>>>>>>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
>>>>>>>> the signing requirements across different SOCs, hopefully will be able to add
>>>>>>>> something on this by then.
>>>>>>
>>>>>> It's been more than a week since the last email. Are there any updates?
>>>>>> I'd really like to get this sorted out before next linux-firmware
>>>>>> release, otherwise we'll be stuck with these names for the foreseeable
>>>>>> future.
>>>>> I have been chasing both the firmware and security folks to align on this. So
>>>>> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
>>>>
>>>> I think the existing firmware uses v3, not v5.
>>>>
>>>> 00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|
>>>>
>>>>
>>>>> to different set of binaries. These MBN versions of signing is defined at SOC
>>>>> level and depends on secure boot libraries used in that SOC.
>>>>> At the same time, there is an experiment to check if SC7180 can be signed with
>>>>> version used for QCS615 i.e MBNV6.
>>>>
>>>> Thanks! Are you trying that without updating the whole bootloader stack? I
>>>> think some of SC7180 devices might be EOL'd, so it might be hard to get
>>>> FW/bootloader updates.
>>> Just the firmware part, by signing it with qcs615 way, as an experiment
>>> suggested by security folks.
>>
>> Ok, that doesn't sound like a lengthy experiment: resign the FW, boot
>> the laptop, caboom or not caboom. If I remember correctly the file that
>> you've pushed even lists sc7180 as allowed.
> its used only for qcs615.
some good news, we could now have qcs615 firmware as common for both qcs615 as
well as sc7180. A PR would be raised to updated 5.4/venus.mbn and at the same
time to delete 5.4/venus_s6.mbn.

Regards,
Vikash
>>
>>>
>>>>> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
>>>>> is not enabled yet (patches in review) for video, we should be good if we
>>>>> conclude the firmware part before accepting the qcs615 enablement patches ?
>>>>
>>>> Good question. I think that depends on linux-firmware maintainer's
>>>> opinion.
>>>>
>>

Re: add venus firmware file for qcs615

[Dmitry Baryshkov]

On Thu, 12 Dec 2024 at 10:22, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>
>
> On 12/2/2024 8:51 PM, Vikash Garodia wrote:
> >
> > On 12/2/2024 8:41 PM, Dmitry Baryshkov wrote:
> >> On Mon, Dec 02, 2024 at 06:20:40PM +0530, Vikash Garodia wrote:
> >>>
> >>> On 12/2/2024 6:16 PM, Dmitry Baryshkov wrote:
> >>>> On Mon, Dec 02, 2024 at 05:30:55PM +0530, Vikash Garodia wrote:
> >>>>> Hi Dmitry,
> >>>>>
> >>>>> On 11/29/2024 8:05 PM, Dmitry Baryshkov wrote:
> >>>>>> On Wed, Nov 20, 2024 at 01:22:50PM +0200, Dmitry Baryshkov wrote:
> >>>>>>> On Wed, Nov 20, 2024 at 04:40:51PM +0530, Vikash Garodia wrote:
> >>>>>>>>
> >>>>>>>> On 11/20/2024 4:09 PM, Dmitry Baryshkov wrote:
> >>>>>>>>> On Thu, Nov 14, 2024 at 01:31:14PM +0200, Dmitry Baryshkov wrote:
> >>>>>>>>>> On Thu, 14 Nov 2024 at 13:05, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> On 11/14/2024 4:16 PM, Dmitry Baryshkov wrote:
> >>>>>>>>>>>> On Thu, Nov 14, 2024 at 09:06:55AM +0530, Vikash Garodia wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> On 11/13/2024 8:10 PM, Dmitry Baryshkov wrote:
> >>>>>>>>>>>>>> On Wed, Nov 13, 2024 at 10:50:44AM +0000, Renjiang Han (QUIC) wrote:
> >>>>>>>>>>>>>>> Hello
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> The following changes since commit 6482750d396980a31f76edd5a84b03a96bbdf3fe:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>   Merge branch 'verb' into 'main' (2024-11-11 20:01:00 +0000)
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> are available in the Git repository at:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>   git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git<mailto:git@git.codelinaro.org:clo/linux-kernel/linux-firmware.git> video-firmware-qcs615
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> for you to fetch changes up to 1e7f65883150d3b48307b4f0d6871c60151ee25b:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>   qcom: venus-5.4: add venus firmware file for qcs615 (2024-11-13 15:50:29 +0530)
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> ----------------------------------------------------------------
> >>>>>>>>>>>>>>> Renjiang Han (1):
> >>>>>>>>>>>>>>>       qcom: venus-5.4: add venus firmware file for qcs615
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> WHENCE                      |   1 +
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Could you please be more specific, what is the difference between the
> >>>>>>>>>>>>>> existing file and a new file? According to the soc_vers the new file
> >>>>>>>>>>>>>> supports sdm845. Should it instead replace the old firmware?
> >>>>>>>>>>>>> SDM845, SC7180, qcs615 can be enabled on same firmware ideally, but due to a
> >>>>>>>>>>>>> different signing for qcs615, it takes a separate bin (xxx_s6.mbn).
> >>>>>>>>>>>>
> >>>>>>>>>>>> Can SDM845 handle v6 signatures? It supports v5 and PSS. Or can QCS615
> >>>>>>>>>>>> use v5 signatures?
> >>>>>>>>>>> Infact we started with loading sc7180 firmware on qc615, video init failed. So
> >>>>>>>>>>> far i have seen 2 categories in signing version for video bins, either default
> >>>>>>>>>>> or v6 specific tool.
> >>>>>>>>>>
> >>>>>>>>>> Can firmware / security engineers actually advice us on using v5
> >>>>>>>>>> firmware signatures with QCS615 _and_ with older platforms?
> >>>>>>>>>> Existing venus-5.4/venus.mbn uses v3
> >>>>>>>>>
> >>>>>>>>> Vikash, any updates on this topic? Would it be possible to have a single
> >>>>>>>>> FW image with just v5 signatures?
> >>>>>>>> Not yet Dmitry. Having a followup with relevant folks this friday to understand
> >>>>>>>> the signing requirements across different SOCs, hopefully will be able to add
> >>>>>>>> something on this by then.
> >>>>>>
> >>>>>> It's been more than a week since the last email. Are there any updates?
> >>>>>> I'd really like to get this sorted out before next linux-firmware
> >>>>>> release, otherwise we'll be stuck with these names for the foreseeable
> >>>>>> future.
> >>>>> I have been chasing both the firmware and security folks to align on this. So
> >>>>> far the updates are that one is signed MBNv5 and other with MBNV6, hence leading
> >>>>
> >>>> I think the existing firmware uses v3, not v5.
> >>>>
> >>>> 00001000  00 00 00 00 03 00 00 00  00 00 00 00 28 00 a0 0f  |............(...|
> >>>>
> >>>>
> >>>>> to different set of binaries. These MBN versions of signing is defined at SOC
> >>>>> level and depends on secure boot libraries used in that SOC.
> >>>>> At the same time, there is an experiment to check if SC7180 can be signed with
> >>>>> version used for QCS615 i.e MBNV6.
> >>>>
> >>>> Thanks! Are you trying that without updating the whole bootloader stack? I
> >>>> think some of SC7180 devices might be EOL'd, so it might be hard to get
> >>>> FW/bootloader updates.
> >>> Just the firmware part, by signing it with qcs615 way, as an experiment
> >>> suggested by security folks.
> >>
> >> Ok, that doesn't sound like a lengthy experiment: resign the FW, boot
> >> the laptop, caboom or not caboom. If I remember correctly the file that
> >> you've pushed even lists sc7180 as allowed.
> > its used only for qcs615.
> some good news, we could now have qcs615 firmware as common for both qcs615 as
> well as sc7180. A PR would be raised to updated 5.4/venus.mbn and at the same
> time to delete 5.4/venus_s6.mbn.

Note, 5.4/venus_s6.mbn has been included into December release, so
ideally you have to provide backwards compatible link (unless
maintainers allow you to skip one).

>
> Regards,
> Vikash
> >>
> >>>
> >>>>> One query here - given that qcs615 only loads the venus_s6.mbn variant, and it
> >>>>> is not enabled yet (patches in review) for video, we should be good if we
> >>>>> conclude the firmware part before accepting the qcs615 enablement patches ?
> >>>>
> >>>> Good question. I think that depends on linux-firmware maintainer's
> >>>> opinion.
> >>>>
> >>



-- 
With best wishes
Dmitry