Re: [PATCH 1/4] dt-bindings: thermal: qoriq: Update compatible string for imx93

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/07/2025 04:40, Jacky Bai wrote:
> The TMU used on i.MX93 has some slight differances and bugs compared to

Typo

> the one used on qoriq platform even the basic function is the same. Add

qoriq? Qoriq?

> imx93 specific compatible string and keep the fallback ability.

imx93? I.MX93? Can you use proper names for OWN products?

> 
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---
>  .../devicetree/bindings/thermal/qoriq-thermal.yaml       | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> index aa756dae512a..cc65e210e26b 100644
> --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> @@ -22,9 +22,12 @@ properties:
>              Value           Device
>              ----------      -----
>              0x01900102      T1040
> -    enum:
> -      - fsl,qoriq-tmu
> -      - fsl,imx8mq-tmu
> +    oneOf:
> +      - const: fsl,qoriq-tmu
> +      - const: fsl,imx8mq-tmu


That's still enum. Don't change that.

> +      - items:
> +          - const: fsl,imx93-tmu
> +          - const: fsl,qoriq-tmu
>  
>    reg:
>      maxItems: 1


Best regards,
Krzysztof