From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacky Bai <ping.bai@nxp.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>
Subject: Re: [PATCH 2/4] thermal: qoriq: add i.MX93 TMU support
Date: Tue, 29 Jul 2025 10:07:54 +0200 [thread overview]
Message-ID: <db07bf8a-67ba-40fe-ad38-a76ad551dbf7@kernel.org> (raw)
In-Reply-To: <AS8PR04MB8642DDDAF4E9CA5E98F94E9B8725A@AS8PR04MB8642.eurprd04.prod.outlook.com>
On 29/07/2025 10:02, Jacky Bai wrote:
>> Subject: Re: [PATCH 2/4] thermal: qoriq: add i.MX93 TMU support
>>
> ...
>
>>> +325,9 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
>>>
>>> data->ver = (ver >> 8) & 0xff;
>>>
>>> + if (of_find_compatible_node(NULL, NULL, "fsl,imx93-tmu"))
>>> + data->ver = TMU_VER93;
>>
>> No, you have driver match data for this.
>>
>
> No compatible specific data info provided in the driver, will use
> the 'of_device_is_compatible' to refine the above changes.
Again, no. This does not scale, use standard methods.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-29 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 2:40 [PATCH 1/4] dt-bindings: thermal: qoriq: Update compatible string for imx93 Jacky Bai
2025-07-29 2:40 ` [PATCH 2/4] thermal: qoriq: add i.MX93 TMU support Jacky Bai
2025-07-29 6:42 ` Krzysztof Kozlowski
2025-07-29 8:02 ` Jacky Bai
2025-07-29 8:07 ` Krzysztof Kozlowski [this message]
2025-07-29 8:21 ` Jacky Bai
2025-07-29 2:40 ` [PATCH 3/4] thermal: qoriq: workaround the tmu temp jump on imx93 Jacky Bai
2025-07-29 2:40 ` [PATCH 4/4] arm64: dts: imx93: update the tmu compatible string Jacky Bai
2025-07-29 6:41 ` [PATCH 1/4] dt-bindings: thermal: qoriq: Update compatible string for imx93 Krzysztof Kozlowski
2025-07-29 6:52 ` Jacky Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db07bf8a-67ba-40fe-ad38-a76ad551dbf7@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.