All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: Niklas Cassel <cassel@kernel.org>, Hannes Reinecke <hare@suse.de>,
	 Daniel Wagner <dwagner@suse.de>,
	Stuart Hayes <stuart.w.hayes@gmail.com>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: core: shorten duration of multipath namespace rescan
Date: Mon, 26 Aug 2024 17:46:10 +0200	[thread overview]
Message-ID: <a5b9abcf03302d6f5c5b163c97070c4a674e02e8.camel@suse.com> (raw)
In-Reply-To: <3d52c916-a152-4f1e-8b44-6c4c1ca34747@grimberg.me>

On Mon, 2024-08-26 at 17:30 +0300, Sagi Grimberg wrote:
> 
> I'd even make it nicer with adding an out label and reverse the ret 
> condition polarity.

Ok, if you prefer that ... I thought you might like the if block
better, as the goto variant comes with lots of whitespace changes.
I'll send a v3.

Thanks
Martin



  parent reply	other threads:[~2024-08-26 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 14:22 [PATCH v2] nvme: core: shorten duration of multipath namespace rescan Martin Wilck
2024-08-26 14:30 ` Sagi Grimberg
2024-08-26 14:31   ` Sagi Grimberg
2024-08-26 15:46   ` Martin Wilck [this message]
2024-08-27  7:33 ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5b9abcf03302d6f5c5b163c97070c4a674e02e8.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=axboe@kernel.dk \
    --cc=cassel@kernel.org \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.