From: Tero Kristo <t-kristo@ti.com>
To: Bhumika Goyal <bhumirks@gmail.com>, <julia.lawall@lip6.fr>,
<mturquette@baylibre.com>, <sboyd@codeaurora.org>,
<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: ti: make clk_ops const
Date: Wed, 23 Aug 2017 12:31:22 +0300 [thread overview]
Message-ID: <a7632b61-a3de-e4c5-032d-e91fbb7b5f4e@ti.com> (raw)
In-Reply-To: <1503407475-11620-1-git-send-email-bhumirks@gmail.com>
=EF=BB=BF
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Bu=
siness ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 22/08/17 16:11, Bhumika Goyal wrote:
> Make these const as they are only stored in the const field of a
> clk_init_data structure.
>=20
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Looks fine.
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/clk/ti/adpll.c | 2 +-
> drivers/clk/ti/apll.c | 2 +-
> drivers/clk/ti/fapll.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index 255cafb..d5c6db4 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw)
> return 0;
> }
> =20
> -static struct clk_ops ti_adpll_ops =3D {
> +static const struct clk_ops ti_adpll_ops =3D {
> .prepare =3D ti_adpll_prepare,
> .unprepare =3D ti_adpll_unprepare,
> .is_prepared =3D ti_adpll_is_prepared,
> diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
> index 06f486b..83b148f 100644
> --- a/drivers/clk/ti/apll.c
> +++ b/drivers/clk/ti/apll.c
> @@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw)
> ti_clk_ll_ops->clk_writel(v, &ad->control_reg);
> }
> =20
> -static struct clk_ops omap2_apll_ops =3D {
> +static const struct clk_ops omap2_apll_ops =3D {
> .enable =3D &omap2_apll_enable,
> .disable =3D &omap2_apll_disable,
> .is_enabled =3D &omap2_apll_is_enabled,
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index 66a0d0e..071af44 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsig=
ned long rate,
> return 0;
> }
> =20
> -static struct clk_ops ti_fapll_ops =3D {
> +static const struct clk_ops ti_fapll_ops =3D {
> .enable =3D ti_fapll_enable,
> .disable =3D ti_fapll_disable,
> .is_enabled =3D ti_fapll_is_enabled,
> @@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw,=
unsigned long rate,
> return 0;
> }
> =20
> -static struct clk_ops ti_fapll_synt_ops =3D {
> +static const struct clk_ops ti_fapll_synt_ops =3D {
> .enable =3D ti_fapll_synth_enable,
> .disable =3D ti_fapll_synth_disable,
> .is_enabled =3D ti_fapll_synth_is_enabled,
>=20
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
julia.lawall@lip6.fr, mturquette@baylibre.com,
sboyd@codeaurora.org, linux-omap@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ti: make clk_ops const
Date: Wed, 23 Aug 2017 12:31:22 +0300 [thread overview]
Message-ID: <a7632b61-a3de-e4c5-032d-e91fbb7b5f4e@ti.com> (raw)
In-Reply-To: <1503407475-11620-1-git-send-email-bhumirks@gmail.com>
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 22/08/17 16:11, Bhumika Goyal wrote:
> Make these const as they are only stored in the const field of a
> clk_init_data structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Looks fine.
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/clk/ti/adpll.c | 2 +-
> drivers/clk/ti/apll.c | 2 +-
> drivers/clk/ti/fapll.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index 255cafb..d5c6db4 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw)
> return 0;
> }
>
> -static struct clk_ops ti_adpll_ops = {
> +static const struct clk_ops ti_adpll_ops = {
> .prepare = ti_adpll_prepare,
> .unprepare = ti_adpll_unprepare,
> .is_prepared = ti_adpll_is_prepared,
> diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
> index 06f486b..83b148f 100644
> --- a/drivers/clk/ti/apll.c
> +++ b/drivers/clk/ti/apll.c
> @@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw)
> ti_clk_ll_ops->clk_writel(v, &ad->control_reg);
> }
>
> -static struct clk_ops omap2_apll_ops = {
> +static const struct clk_ops omap2_apll_ops = {
> .enable = &omap2_apll_enable,
> .disable = &omap2_apll_disable,
> .is_enabled = &omap2_apll_is_enabled,
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index 66a0d0e..071af44 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> -static struct clk_ops ti_fapll_ops = {
> +static const struct clk_ops ti_fapll_ops = {
> .enable = ti_fapll_enable,
> .disable = ti_fapll_disable,
> .is_enabled = ti_fapll_is_enabled,
> @@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> -static struct clk_ops ti_fapll_synt_ops = {
> +static const struct clk_ops ti_fapll_synt_ops = {
> .enable = ti_fapll_synth_enable,
> .disable = ti_fapll_synth_disable,
> .is_enabled = ti_fapll_synth_is_enabled,
>
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Bhumika Goyal <bhumirks@gmail.com>, <julia.lawall@lip6.fr>,
<mturquette@baylibre.com>, <sboyd@codeaurora.org>,
<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: ti: make clk_ops const
Date: Wed, 23 Aug 2017 12:31:22 +0300 [thread overview]
Message-ID: <a7632b61-a3de-e4c5-032d-e91fbb7b5f4e@ti.com> (raw)
In-Reply-To: <1503407475-11620-1-git-send-email-bhumirks@gmail.com>
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 22/08/17 16:11, Bhumika Goyal wrote:
> Make these const as they are only stored in the const field of a
> clk_init_data structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Looks fine.
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/clk/ti/adpll.c | 2 +-
> drivers/clk/ti/apll.c | 2 +-
> drivers/clk/ti/fapll.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index 255cafb..d5c6db4 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw)
> return 0;
> }
>
> -static struct clk_ops ti_adpll_ops = {
> +static const struct clk_ops ti_adpll_ops = {
> .prepare = ti_adpll_prepare,
> .unprepare = ti_adpll_unprepare,
> .is_prepared = ti_adpll_is_prepared,
> diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
> index 06f486b..83b148f 100644
> --- a/drivers/clk/ti/apll.c
> +++ b/drivers/clk/ti/apll.c
> @@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw)
> ti_clk_ll_ops->clk_writel(v, &ad->control_reg);
> }
>
> -static struct clk_ops omap2_apll_ops = {
> +static const struct clk_ops omap2_apll_ops = {
> .enable = &omap2_apll_enable,
> .disable = &omap2_apll_disable,
> .is_enabled = &omap2_apll_is_enabled,
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index 66a0d0e..071af44 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> -static struct clk_ops ti_fapll_ops = {
> +static const struct clk_ops ti_fapll_ops = {
> .enable = ti_fapll_enable,
> .disable = ti_fapll_disable,
> .is_enabled = ti_fapll_is_enabled,
> @@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> -static struct clk_ops ti_fapll_synt_ops = {
> +static const struct clk_ops ti_fapll_synt_ops = {
> .enable = ti_fapll_synth_enable,
> .disable = ti_fapll_synth_disable,
> .is_enabled = ti_fapll_synth_is_enabled,
>
next prev parent reply other threads:[~2017-08-23 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 13:11 [PATCH] clk: ti: make clk_ops const Bhumika Goyal
2017-08-23 9:31 ` Tero Kristo [this message]
2017-08-23 9:31 ` Tero Kristo
2017-08-23 9:31 ` Tero Kristo
2017-08-23 22:53 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7632b61-a3de-e4c5-032d-e91fbb7b5f4e@ti.com \
--to=t-kristo@ti.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.