All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
To: Michael Walle <michael@walle.cc>
Cc: linux-mtd@lists.infradead.org,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: Add support for mx66l2g45g
Date: Mon, 23 May 2022 23:03:49 +0800	[thread overview]
Message-ID: <a7bbd451-e054-c69c-6e39-e73320878b8f@linux.intel.com> (raw)
In-Reply-To: <35d64d702798d437245090ce96ae29a8@walle.cc>

On 2022-05-23 22:59, Michael Walle wrote:
> Am 2022-05-23 16:33, schrieb Jiaqing Zhao:
>> Use PARSE_SFDP for now as the SNOR_ID3() patch is not merged yet, will
>> switch to it after it is merged.
> 
> Fair enough, could you resubmit it with
> { "mx66l2g45g",  INFO(0xc2201c, 0, 0, 0) PARSE_SFDP },
> 
> Looks odd, but is the same as SNOR_ID3(0xc2201c), so we can just
> switch to the new macro without any more testing. Or Pratyush can
> replace it inline while committing this patch if the SNOR_ID3()
> will make it in before.

I'll add a TODO comment in case we forgot it.

> -michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
To: Michael Walle <michael@walle.cc>
Cc: linux-mtd@lists.infradead.org,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: Add support for mx66l2g45g
Date: Mon, 23 May 2022 23:03:49 +0800	[thread overview]
Message-ID: <a7bbd451-e054-c69c-6e39-e73320878b8f@linux.intel.com> (raw)
In-Reply-To: <35d64d702798d437245090ce96ae29a8@walle.cc>

On 2022-05-23 22:59, Michael Walle wrote:
> Am 2022-05-23 16:33, schrieb Jiaqing Zhao:
>> Use PARSE_SFDP for now as the SNOR_ID3() patch is not merged yet, will
>> switch to it after it is merged.
> 
> Fair enough, could you resubmit it with
> { "mx66l2g45g",  INFO(0xc2201c, 0, 0, 0) PARSE_SFDP },
> 
> Looks odd, but is the same as SNOR_ID3(0xc2201c), so we can just
> switch to the new macro without any more testing. Or Pratyush can
> replace it inline while committing this patch if the SNOR_ID3()
> will make it in before.

I'll add a TODO comment in case we forgot it.

> -michael

  reply	other threads:[~2022-05-23 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 14:30 [PATCH v2] mtd: spi-nor: macronix: Add support for mx66l2g45g Jiaqing Zhao
2022-05-23 14:30 ` Jiaqing Zhao
2022-05-23 14:33 ` Jiaqing Zhao
2022-05-23 14:33   ` Jiaqing Zhao
2022-05-23 14:59   ` Michael Walle
2022-05-23 14:59     ` Michael Walle
2022-05-23 15:03     ` Jiaqing Zhao [this message]
2022-05-23 15:03       ` Jiaqing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7bbd451-e054-c69c-6e39-e73320878b8f@linux.intel.com \
    --to=jiaqing.zhao@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=p.yadav@ti.com \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.