From: "Andy Yan" <andyshrk@163.com>
To: "Andrew Lunn" <andrew@lunn.ch>
Cc: "Johan Jonker" <jbx6244@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, david.wu@rock-chips.com,
andy.yan@rock-chips.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re:Re: [PATCH v1 2/2] net: arc: rockchip: fix emac mdio node support
Date: Tue, 29 Oct 2024 16:22:16 +0800 (CST) [thread overview]
Message-ID: <a7c2431.871a.192d75e5631.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <0a60a838-42cb-4df8-ab1f-91002dcaaa14@lunn.ch>
Hi Andrew,
At 2024-10-28 20:59:18, "Andrew Lunn" <andrew@lunn.ch> wrote:
>> Hello Johan,
>> Thanks for your patch. Maybe we need a Fixes tag here?
>
>What is actually broken?
The emac failed to probe after bellow patch merged.
[ 2.324583] loop: module loaded
[ 2.328435] SPI driver spidev has no spi_device_id for rockchip,spidev
[ 2.338688] tun: Universal TUN/TAP device driver, 1.6
[ 2.345397] rockchip_emac 10200000.ethernet: no regulator found
[ 2.351892] rockchip_emac 10200000.ethernet: ARC EMAC detected with id: 0x7fd02
[ 2.359331] rockchip_emac 10200000.ethernet: IRQ is 43
[ 2.364719] rockchip_emac 10200000.ethernet: MAC address is now e6:58:d6:ec:d9:7c
[ 2.396993] mdio_bus Synopsys MII Bus: mdio has invalid PHY address
[ 2.403306] mdio_bus Synopsys MII Bus: scan phy mdio at address 0
[ 2.508656] rockchip_emac 10200000.ethernet: of_phy_connect() failed
[ 2.516334] rockchip_emac 10200000.ethernet: failed to probe arc emac (-19)
commit 1dabb74971b38d966ecef566bafddc4a34f4db9d
Author: Johan Jonker <jbx6244@gmail.com>
Date: Fri Jun 3 18:35:39 2022 +0200
ARM: dts: rockchip: restyle emac nodes
The emac_rockchip.txt file is converted to YAML.
Phy nodes are now a subnode of mdio, so restyle
the emac nodes of rk3036/rk3066/rk3188.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://lore.kernel.org/r/20220603163539.537-3-jbx6244@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Andrew
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Andy Yan" <andyshrk@163.com>
To: "Andrew Lunn" <andrew@lunn.ch>
Cc: "Johan Jonker" <jbx6244@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, david.wu@rock-chips.com,
andy.yan@rock-chips.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re:Re: [PATCH v1 2/2] net: arc: rockchip: fix emac mdio node support
Date: Tue, 29 Oct 2024 16:22:16 +0800 (CST) [thread overview]
Message-ID: <a7c2431.871a.192d75e5631.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <0a60a838-42cb-4df8-ab1f-91002dcaaa14@lunn.ch>
Hi Andrew,
At 2024-10-28 20:59:18, "Andrew Lunn" <andrew@lunn.ch> wrote:
>> Hello Johan,
>> Thanks for your patch. Maybe we need a Fixes tag here?
>
>What is actually broken?
The emac failed to probe after bellow patch merged.
[ 2.324583] loop: module loaded
[ 2.328435] SPI driver spidev has no spi_device_id for rockchip,spidev
[ 2.338688] tun: Universal TUN/TAP device driver, 1.6
[ 2.345397] rockchip_emac 10200000.ethernet: no regulator found
[ 2.351892] rockchip_emac 10200000.ethernet: ARC EMAC detected with id: 0x7fd02
[ 2.359331] rockchip_emac 10200000.ethernet: IRQ is 43
[ 2.364719] rockchip_emac 10200000.ethernet: MAC address is now e6:58:d6:ec:d9:7c
[ 2.396993] mdio_bus Synopsys MII Bus: mdio has invalid PHY address
[ 2.403306] mdio_bus Synopsys MII Bus: scan phy mdio at address 0
[ 2.508656] rockchip_emac 10200000.ethernet: of_phy_connect() failed
[ 2.516334] rockchip_emac 10200000.ethernet: failed to probe arc emac (-19)
commit 1dabb74971b38d966ecef566bafddc4a34f4db9d
Author: Johan Jonker <jbx6244@gmail.com>
Date: Fri Jun 3 18:35:39 2022 +0200
ARM: dts: rockchip: restyle emac nodes
The emac_rockchip.txt file is converted to YAML.
Phy nodes are now a subnode of mdio, so restyle
the emac nodes of rk3036/rk3066/rk3188.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://lore.kernel.org/r/20220603163539.537-3-jbx6244@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Andrew
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-10-29 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 9:41 [PATCH v1 1/2] ethernet: arc: fix the device for dma_map_single/dma_unmap_single Johan Jonker
2024-10-27 9:41 ` Johan Jonker
2024-10-27 9:42 ` [PATCH v1 2/2] net: arc: rockchip: fix emac mdio node support Johan Jonker
2024-10-27 9:42 ` Johan Jonker
2024-10-27 9:58 ` Andy Yan
2024-10-27 9:58 ` Andy Yan
2024-10-28 12:59 ` [PATCH " Andrew Lunn
2024-10-28 12:59 ` Andrew Lunn
2024-10-29 8:22 ` Andy Yan [this message]
2024-10-29 8:22 ` Andy Yan
2024-10-29 12:46 ` Andrew Lunn
2024-10-29 12:46 ` Andrew Lunn
2024-10-28 13:03 ` [PATCH v1 1/2] ethernet: arc: fix the device for dma_map_single/dma_unmap_single Andrew Lunn
2024-10-28 13:03 ` Andrew Lunn
2024-10-29 14:53 ` Johan Jonker
2024-10-29 14:53 ` Johan Jonker
2024-10-30 0:19 ` Andy Yan
2024-10-30 0:19 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7c2431.871a.192d75e5631.Coremail.andyshrk@163.com \
--to=andyshrk@163.com \
--cc=andrew@lunn.ch \
--cc=andy.yan@rock-chips.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=edumazet@google.com \
--cc=jbx6244@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.