From: Andrej Krpic <ak77@tnode.com>
To: Joe Perches <joe@perches.com>
Cc: <linux-kernel@vger.kernel.org>, <jslaby@suse.com>,
<gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/8] tty: n_gsm: fix formatting errors
Date: Tue, 23 Feb 2016 00:37:14 +0000 [thread overview]
Message-ID: <a8e96899bf9d42998a848e97951df26f@tnode.com> (raw)
In-Reply-To: <1456093820.31061.7.camel@perches.com>
On 21.02.2016 22:30, Joe Perches wrote:
> On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote:
>> Minor formatting changes to remove errors and reduce number of
>> warnings produced by checkpatch.pl script.
> []
>> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> []
>> @@ -489,7 +490,8 @@ static void gsm_print_packet(const char *hdr,
>> int addr, int cr,
>> if (!(control & 0x01)) {
>> pr_cont("I N(S)%d N(R)%d",
>> (control & 0x0E) >> 1, (control & 0xE0) >> 5);
>> - } else switch (control & 0x0F) {
>> + } else
>> + switch (control & 0x0F) {
>
> Please follow the brace rule for else uses where
> if one branch has braces, the other does too.
Thank you for noticing.
Should I resend this as a single patch or wait for more comments for v2
series?
-Andrej
next prev parent reply other threads:[~2016-02-23 0:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 21:38 [PATCH 0/8] tty: n_gsm: Make mux work as a responder station Andrej Krpic
2016-02-21 21:38 ` [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic
2016-02-21 22:30 ` Joe Perches
2016-02-23 0:37 ` Andrej Krpic [this message]
2016-02-21 21:38 ` [PATCH 2/8] tty: n_gsm: fix C/R bit when sending as a responder Andrej Krpic
2016-02-21 21:38 ` [PATCH 3/8] tty: n_gsm: make mux work as a responder station Andrej Krpic
2016-02-21 21:38 ` [PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel Andrej Krpic
2016-02-21 21:38 ` [PATCH 5/8] tty: n_gsm: replace dead code with a meaningful comment Andrej Krpic
2016-02-21 21:38 ` [PATCH 6/8] tty: n_gsm: add missing length field in control channel commands Andrej Krpic
2016-02-21 21:38 ` [PATCH 7/8] tty: n_gsm: properly format Modem Status Command message Andrej Krpic
2016-02-21 21:38 ` [PATCH 8/8] tty: n_gsm: Enable reception of frames separated with a single SOF marker Andrej Krpic
2016-02-21 23:42 ` [PATCH 0/8] tty: n_gsm: Make mux work as a responder station One Thousand Gnomes
2016-02-23 0:28 ` Andrej Krpic
-- strict thread matches above, loose matches on Subject: below --
2016-02-22 22:53 Andrej Krpic
2016-02-22 22:53 ` [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e96899bf9d42998a848e97951df26f@tnode.com \
--to=ak77@tnode.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.