Re: RE: UDA1341TS (iPAQ H3X00) sound driver for ALSA

Re: RE: UDA1341TS (iPAQ H3X00) sound driver for ALSA

[Takashi Iwai]

At Wed, 10 Apr 2002 09:55:43 -0400,
Hicks, Jamey <Jamey.Hicks@compaq.com> wrote:
> 
> > -----Original Message-----
> > From: Nicolas Pitre [mailto:nico@cam.org]
> > Sent: Wednesday, April 10, 2002 9:47 AM
> > To: Hicks, Jamey
> > Cc: Kasparek Tomas; alsa-devel@lists.sourceforge.net;
> > Linux-arm-kernel@lists.arm.linux.org.uk
> > Subject: RE: UDA1341TS (iPAQ H3X00) sound driver for ALSA
> > 
> > 
> > On Wed, 10 Apr 2002, Hicks, Jamey wrote:
> > 
> > > 
> > > I would prefer that the ALSA driver for the iPAQ have a 
> > different name
> > > than the OSS driver for the iPAQ, since they have different 
> > interfaces.  
> > > How about h3600-alsa?
> > 
> > No.  Please pick a relevant name.  H3600 is not the only 
> > device with an UDA1341 out there.
> 
> The alsa driver mentioned is iPAQ specific.  It would be useful to restructure it in the way the other SA11x0/UDA134x driver is structured.

the alsa modules have "snd-" prefix, so they don't conflict with
others anyway.

IMO, if the driver is iPAQ specific, i prefer a simple name such as
snd-ipaq or snd-ipaq-h3x00.  if a part of the driver will be shared by
others, then we can split it to a lowlevel module with a proper device
name.

just my $0.02.


ciao,

Takashi

Re: RE: UDA1341TS (iPAQ H3X00) sound driver for ALSA

[Kasparek Tomas]

On Wed, 10 Apr 2002, Takashi Iwai wrote:

> > > > I would prefer that the ALSA driver for the iPAQ have a
> > > different name
> > > > than the OSS driver for the iPAQ, since they have different
> > > interfaces.
> > > > How about h3600-alsa?
> > >
> > > No.  Please pick a relevant name.  H3600 is not the only
> > > device with an UDA1341 out there.
> >
> > The alsa driver mentioned is iPAQ specific.  It would be useful to restructure it in the way the other SA11x0/UDA134x driver is structured.
>
> the alsa modules have "snd-" prefix, so they don't conflict with
> others anyway.
>
> IMO, if the driver is iPAQ specific, i prefer a simple name such as
> snd-ipaq or snd-ipaq-h3x00.  if a part of the driver will be shared by
> others, then we can split it to a lowlevel module with a proper device
> name.

Hmm ,I expected comments to driver quality and behavior, not to its
name :).

This is first public release of the driver. UDA1341TS specific part is
placed in "snd-uda1341" module and should be ARM-independent. The rest is
placed in snd-h3600-uda1341. There you could find H3x00 specific parts
same as a bit of SA1100 DMA code. The SA1100 DMA stuff could be moved into
independent module (like sa1100-audio in OSS), but it's just "few lines"
of code now.

The driver could be structuded better of course, but I don't have any
other ARM and/or UDA1341 device to be able to exactly select parts which
are common.

This first release is intended for basic functionality tests. I think,
there is enough time to discuss final names of modules.

Bye

--

	Tomas Kasparek (sioux, xkaspa06)
 	 tomas.kasparek@[seznam.cz,volny.cz]
	 linux@fit.vutbr.cz
	student FIT VUT Brno

Re: RE: UDA1341TS (iPAQ H3X00) sound driver for ALSA

[Kasparek Tomas]

Hi,

I have just created tiny web page with some aditional information.

http://www.stud.fee.vutbr.cz/~xkaspa06/ipaq/

Bye

--

	Tomas Kasparek (sioux, xkaspa06)
 	 tomas.kasparek@[seznam.cz,volny.cz]
	 linux@fit.vutbr.cz
	student FIT VUT Brno

Re: UDA1341TS (iPAQ H3X00) sound driver for ALSA

[Russell King - ARM Linux]

On Wed, Apr 10, 2002 at 09:55:43AM -0400, Hicks, Jamey wrote:
> > -----Original Message-----
> > From: Nicolas Pitre [mailto:nico@cam.org]
> > 
> > No.  Please pick a relevant name.  H3600 is not the only 
> > device with an UDA1341 out there.
> 
> The alsa driver mentioned is iPAQ specific.  It would be useful to
> restructure it in the way the other SA11x0/UDA134x driver is structured.

I agree with Nico.  Nico is objecting to it being called *h3600* when it
is for all iPAQs, ie, H3600, H3100, H3800.