All of lore.kernel.org
 help / color / mirror / Atom feed
From: Binbin Wu <binbin.wu@linux.intel.com>
To: Kiryl Shutsemau <kas@kernel.org>, Peter Fang <peter.fang@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/tdx: Add helper to query maximum TD Quote size
Date: Fri, 10 Jul 2026 10:38:40 +0800	[thread overview]
Message-ID: <a95a286c-5fa9-47f7-8a9a-4ecf3aafdfee@linux.intel.com> (raw)
In-Reply-To: <aiv8mrJDgs_e8eLq@thinkstation>

On 6/12/2026 8:36 PM, Kiryl Shutsemau wrote:
>>  
>> +/**
>> + * tdx_get_max_quote_size() - Get the maximum TD Quote size
>> + *
>> + * Read the maximum size of a TD Quote from a 4-byte TD metadata field. The TDX
>> + * guest driver uses it to size the buffer for Quote retrieval. Older TDX
>> + * modules do not support this field and return an error.
>> + *
>> + * Return: Maximum Quote size in bytes on success, or 0 on failure.
>> + */
>> +u32 tdx_get_max_quote_size(void)
>> +{
>> +	u64 val, ret;
>> +
>> +	ret = tdg_vm_rd(TDCS_QUOTE_MAX_SIZE, &val);
>> +
>> +	return ret ? 0 : (u32)val;
> 
> Cast is redundant.

I thought in Linux kernel, the explicit cast is often preferred?
E.g. as documentation of the metadata field’s width here?

> 
>> +}
>> +EXPORT_SYMBOL_GPL(tdx_get_max_quote_size);
>> +
>>  static void __noreturn tdx_panic(const char *msg)
>>  {
>>  	struct tdx_module_args args = {
> 


  parent reply	other threads:[~2026-07-10  2:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 11:08 [PATCH 0/2] tdx-guest: Make Quote buffer size dynamic Peter Fang
2026-06-12 11:08 ` [PATCH 1/2] x86/tdx: Add helper to query maximum TD Quote size Peter Fang
2026-06-12 12:36   ` Kiryl Shutsemau
2026-06-23  4:30     ` Peter Fang
2026-07-10  2:38     ` Binbin Wu [this message]
2026-07-14  5:54       ` Peter Fang
2026-06-12 14:25   ` Xiaoyao Li
2026-06-23  4:44     ` Peter Fang
2026-07-02 10:16       ` Xiaoyao Li
2026-07-06  9:18         ` Peter Fang
2026-07-13 16:01   ` Kuppuswamy Sathyanarayanan
2026-07-14  5:56     ` Peter Fang
2026-06-12 11:08 ` [PATCH 2/2] virt: tdx-guest: Allocate Quote buffer dynamically Peter Fang
2026-06-12 11:22   ` sashiko-bot
2026-06-12 12:37   ` Kiryl Shutsemau
2026-06-23  5:11     ` Peter Fang
2026-07-10  3:32   ` Binbin Wu
2026-07-14  6:18     ` Peter Fang
2026-07-13 17:27   ` Kuppuswamy Sathyanarayanan
2026-07-14  6:25     ` Peter Fang
2026-07-14 16:22       ` Kuppuswamy Sathyanarayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a95a286c-5fa9-47f7-8a9a-4ecf3aafdfee@linux.intel.com \
    --to=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peter.fang@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.