* [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a
@ 2025-04-16 3:45 WangYuli
2025-04-16 12:06 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: WangYuli @ 2025-04-16 3:45 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, tsbogend
Cc: wangyuli, devicetree, linux-mips, linux-kernel, jiaxun.yang,
chenhuacai, yangtiezhu, zhanjun, niecheng1, guanwentao
Similar to commit 98a9e2ac3755 ("MIPS: Loongson64: DTS: Fix msi node for ls7a").
Fix follow warnings:
arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts:28.31-36.4: Warning (interrupt_provider): /bus@10000000/msi-controller@2ff00000: Missing '#interrupt-cells' in interrupt provider
arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Fixes: 24af105962c8 ("MIPS: Loongson64: DeviceTree for LS7A PCH")
Tested-by: WangYuli <wangyuli@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts b/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
index c7ea4f1c0bb2..6c277ab83d4b 100644
--- a/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
+++ b/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
@@ -29,6 +29,7 @@ msi: msi-controller@2ff00000 {
compatible = "loongson,pch-msi-1.0";
reg = <0 0x2ff00000 0 0x8>;
interrupt-controller;
+ #interrupt-cells = <1>;
msi-controller;
loongson,msi-base-vec = <64>;
loongson,msi-num-vecs = <64>;
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a
2025-04-16 3:45 [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a WangYuli
@ 2025-04-16 12:06 ` Philippe Mathieu-Daudé
2025-04-27 7:54 ` Thomas Bogendoerfer
2025-05-05 11:24 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-16 12:06 UTC (permalink / raw)
To: WangYuli, robh, krzk+dt, conor+dt, tsbogend
Cc: devicetree, linux-mips, linux-kernel, jiaxun.yang, chenhuacai,
yangtiezhu, zhanjun, niecheng1, guanwentao
On 16/4/25 05:45, WangYuli wrote:
> Similar to commit 98a9e2ac3755 ("MIPS: Loongson64: DTS: Fix msi node for ls7a").
>
> Fix follow warnings:
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts:28.31-36.4: Warning (interrupt_provider): /bus@10000000/msi-controller@2ff00000: Missing '#interrupt-cells' in interrupt provider
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
>
> Fixes: 24af105962c8 ("MIPS: Loongson64: DeviceTree for LS7A PCH")
> Tested-by: WangYuli <wangyuli@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a
2025-04-16 3:45 [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a WangYuli
2025-04-16 12:06 ` Philippe Mathieu-Daudé
@ 2025-04-27 7:54 ` Thomas Bogendoerfer
2025-05-05 11:24 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2025-04-27 7:54 UTC (permalink / raw)
To: WangYuli
Cc: robh, krzk+dt, conor+dt, devicetree, linux-mips, linux-kernel,
jiaxun.yang, chenhuacai, yangtiezhu, zhanjun, niecheng1,
guanwentao
On Wed, Apr 16, 2025 at 11:45:48AM +0800, WangYuli wrote:
> Similar to commit 98a9e2ac3755 ("MIPS: Loongson64: DTS: Fix msi node for ls7a").
>
> Fix follow warnings:
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts:28.31-36.4: Warning (interrupt_provider): /bus@10000000/msi-controller@2ff00000: Missing '#interrupt-cells' in interrupt provider
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
>
> Fixes: 24af105962c8 ("MIPS: Loongson64: DeviceTree for LS7A PCH")
> Tested-by: WangYuli <wangyuli@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts b/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
> index c7ea4f1c0bb2..6c277ab83d4b 100644
> --- a/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
> +++ b/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
> @@ -29,6 +29,7 @@ msi: msi-controller@2ff00000 {
> compatible = "loongson,pch-msi-1.0";
> reg = <0 0x2ff00000 0 0x8>;
> interrupt-controller;
> + #interrupt-cells = <1>;
> msi-controller;
> loongson,msi-base-vec = <64>;
> loongson,msi-num-vecs = <64>;
> --
> 2.49.0
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a
2025-04-16 3:45 [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a WangYuli
2025-04-16 12:06 ` Philippe Mathieu-Daudé
2025-04-27 7:54 ` Thomas Bogendoerfer
@ 2025-05-05 11:24 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-05 11:24 UTC (permalink / raw)
To: WangYuli, robh, krzk+dt, conor+dt, tsbogend
Cc: devicetree, linux-mips, linux-kernel, jiaxun.yang, chenhuacai,
yangtiezhu, zhanjun, niecheng1, guanwentao
On 16/04/2025 05:45, WangYuli wrote:
> Similar to commit 98a9e2ac3755 ("MIPS: Loongson64: DTS: Fix msi node for ls7a").
>
> Fix follow warnings:
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts:28.31-36.4: Warning (interrupt_provider): /bus@10000000/msi-controller@2ff00000: Missing '#interrupt-cells' in interrupt provider
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
>
> Fixes: 24af105962c8 ("MIPS: Loongson64: DeviceTree for LS7A PCH")
> Tested-by: WangYuli <wangyuli@uniontech.com>
This is redundant.
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
This implies testing... unless you mean that everything you send is by
default untested? But then please read carefully submitting patches.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-05 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 3:45 [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a WangYuli
2025-04-16 12:06 ` Philippe Mathieu-Daudé
2025-04-27 7:54 ` Thomas Bogendoerfer
2025-05-05 11:24 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.