From: Johan Hovold <johan@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vignesh R <vigneshr@ti.com>, Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH] i2c: omap: fix deprecated of_property_read_bool() use
Date: Fri, 18 Apr 2025 11:57:57 +0200 [thread overview]
Message-ID: <aAIiJQVAUdWJFVy7@hovoldconsulting.com> (raw)
In-Reply-To: <vcwjwrjgzwoil5ydds4findhcgl2ujoxwia7eh7yrbdc45yx26@kmpmvataffzr>
On Thu, Apr 17, 2025 at 11:41:51PM +0200, Andi Shyti wrote:
> On Tue, Apr 15, 2025 at 09:52:30AM +0200, Johan Hovold wrote:
> > Using of_property_read_bool() for non-boolean properties is deprecated
> > and results in a warning during runtime since commit c141ecc3cecd ("of:
> > Warn when of_property_read_bool() is used on non-boolean properties").
> >
> > Fixes: b6ef830c60b6 ("i2c: omap: Add support for setting mux")
> > Cc: Jayesh Choudhary <j-choudhary@ti.com>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> Thanks for your patch! I'm going to drop the Fixes tag, as this
> isn't really a bug fix but rather a warning suppression during
> boot time.
Thanks, but I think you should have kept the Fixes tag and merged this
for 6.15 (i2c-host-fixes) since this is a new warning in 6.15-rc1 (and
that does warrant a Fixes tag). Perhaps I should have highlighted that
better.
If the offending patch had been posted or merged before such uses
started generating warnings in 6.14-rc1 then that would have been a
different matter.
Johan
next prev parent reply other threads:[~2025-04-18 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 7:52 [PATCH] i2c: omap: fix deprecated of_property_read_bool() use Johan Hovold
2025-04-15 11:48 ` Mukesh Kumar Savaliya
2025-04-17 21:41 ` Andi Shyti
2025-04-17 22:18 ` Andi Shyti
2025-04-18 9:57 ` Johan Hovold [this message]
2025-04-29 13:10 ` Andi Shyti
2025-05-02 12:54 ` Andreas Kemnade
2025-05-05 10:00 ` Johan Hovold
2025-05-05 22:13 ` Andi Shyti
2025-05-06 7:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAIiJQVAUdWJFVy7@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=j-choudhary@ti.com \
--cc=jmkrzyszt@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.