Re: [PATCH] i2c: omap: fix deprecated of_property_read_bool() use

[Johan Hovold <johan@kernel.org>]

On Tue, May 06, 2025 at 12:13:00AM +0200, Andi Shyti wrote:
> On Mon, May 05, 2025 at 12:00:07PM +0200, Johan Hovold wrote:
> > On Tue, Apr 29, 2025 at 03:10:13PM +0200, Andi Shyti wrote:

> > > I'm sorry, but as I understand it, the Fixes tag should be used
> > > only when an actual bug is being fixed. I've seen stable
> > > maintainers getting annoyed when it's used for non-bug issues.
> > 
> > You seem to confuse the Fixes tag with a CC stable tag. A Fixes tag is
> > used to indicate which commit introduced an issue, while the CC stable
> > tag is used to flag a commit for backporting (and the fact that autosel
> > tends to pick up patches with just a Fixes doesn't change this).
> 
> (the Cc tag for fixes is not mandatory, it's more a courtesy)

You should still add it as described by the stable tree docs:

	To have a patch you submit for mainline inclusion later
	automatically picked up for stable trees, add this tag in the
	sign-off area::

	Cc: stable@vger.kernel.org

The stable team also scans through patches with just a Fixes tag because
some people forget to add the tag, don't know that they should, or don't
care about stable, but you should not rely on that (as I alluded to
above).

> > It's perfectly fine to fix an issue and use a Fixes tag when doing so
> > even if the fix itself does not qualify for backporting (for whatever
> > reason).
> 
> Oh yes, I forgot that patch was part of the 6.15 merge window. I
> will then move it to the -fixes and send it for this week's merge
> request.

Perfect, thanks.

Johan