Re: [PATCH v2 7/8] platform/chrome: of_hw_prober: Support trackpad probing on Corsola family

[Benson Leung <bleung@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]

On Mon, Apr 21, 2025 at 06:12:45PM +0800, Chen-Yu Tsai wrote:
> Various MT8186 Corsola Chromebooks (squirtle, steelix and voltorb
> families) have second source trackpads that need to be probed.
> The power supply for these are always on and their reset/enable
> lines are not exposed.
> 
> Add them to the probing list.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
> Changes since v1:
> - Rebased and resolved conflicts with "spherion" trackpad prober
> ---
>  drivers/platform/chrome/chromeos_of_hw_prober.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/platform/chrome/chromeos_of_hw_prober.c b/drivers/platform/chrome/chromeos_of_hw_prober.c
> index 019578bc7ad0..10dbaede0541 100644
> --- a/drivers/platform/chrome/chromeos_of_hw_prober.c
> +++ b/drivers/platform/chrome/chromeos_of_hw_prober.c
> @@ -57,6 +57,7 @@ static int chromeos_i2c_component_prober(struct device *dev, const void *_data)
>  	}
>  
>  DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(touchscreen);
> +DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(trackpad);
>  
>  DEFINE_CHROMEOS_I2C_PROBE_CFG_SIMPLE_BY_TYPE(trackpad);
>  
> @@ -88,6 +89,18 @@ static const struct hw_prober_entry hw_prober_platforms[] = {
>  		.compatible = "google,spherion",
>  		.prober = chromeos_i2c_component_prober,
>  		.data = &chromeos_i2c_probe_hana_trackpad,
> +	}, {
> +		.compatible = "google,squirtle",
> +		.prober = chromeos_i2c_component_prober,
> +		.data = &chromeos_i2c_probe_dumb_trackpad,
> +	}, {
> +		.compatible = "google,steelix",
> +		.prober = chromeos_i2c_component_prober,
> +		.data = &chromeos_i2c_probe_dumb_trackpad,
> +	}, {
> +		.compatible = "google,voltorb",
> +		.prober = chromeos_i2c_component_prober,
> +		.data = &chromeos_i2c_probe_dumb_trackpad,
>  	},
>  };
>  
> -- 
> 2.49.0.805.g082f7c87e0-goog
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]