Re: [PATCH v2 8/8] platform/chrome: of_hw_prober: Support touchscreen probing on Squirtle

[Benson Leung <bleung@google.com>]

[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]

On Mon, Apr 21, 2025 at 06:12:46PM +0800, Chen-Yu Tsai wrote:
> The MT8186 Squirtle Chromebook is built with one of two possible
> touchscreens. Let the prober probe for them.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: Benson Leung <bleung@chromium.org>


> ---
>  drivers/platform/chrome/chromeos_of_hw_prober.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/platform/chrome/chromeos_of_hw_prober.c b/drivers/platform/chrome/chromeos_of_hw_prober.c
> index 10dbaede0541..f3cd612e5584 100644
> --- a/drivers/platform/chrome/chromeos_of_hw_prober.c
> +++ b/drivers/platform/chrome/chromeos_of_hw_prober.c
> @@ -59,6 +59,7 @@ static int chromeos_i2c_component_prober(struct device *dev, const void *_data)
>  DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(touchscreen);
>  DEFINE_CHROMEOS_I2C_PROBE_DATA_DUMB_BY_TYPE(trackpad);
>  
> +DEFINE_CHROMEOS_I2C_PROBE_CFG_SIMPLE_BY_TYPE(touchscreen);
>  DEFINE_CHROMEOS_I2C_PROBE_CFG_SIMPLE_BY_TYPE(trackpad);
>  
>  static const struct chromeos_i2c_probe_data chromeos_i2c_probe_hana_trackpad = {
> @@ -76,6 +77,17 @@ static const struct chromeos_i2c_probe_data chromeos_i2c_probe_hana_trackpad = {
>  	},
>  };
>  
> +static const struct chromeos_i2c_probe_data chromeos_i2c_probe_squirtle_touchscreen = {
> +	.cfg = &chromeos_i2c_probe_simple_touchscreen_cfg,
> +	.opts = &(const struct i2c_of_probe_simple_opts) {
> +		.res_node_compatible = "elan,ekth6a12nay",
> +		.supply_name = "vcc33",
> +		.gpio_name = "reset",
> +		.post_power_on_delay_ms = 10,
> +		.post_gpio_config_delay_ms = 300,
> +	},
> +};
> +
>  static const struct hw_prober_entry hw_prober_platforms[] = {
>  	{
>  		.compatible = "google,hana",
> @@ -93,6 +105,10 @@ static const struct hw_prober_entry hw_prober_platforms[] = {
>  		.compatible = "google,squirtle",
>  		.prober = chromeos_i2c_component_prober,
>  		.data = &chromeos_i2c_probe_dumb_trackpad,
> +	}, {
> +		.compatible = "google,squirtle",
> +		.prober = chromeos_i2c_component_prober,
> +		.data = &chromeos_i2c_probe_squirtle_touchscreen,
>  	}, {
>  		.compatible = "google,steelix",
>  		.prober = chromeos_i2c_component_prober,
> -- 
> 2.49.0.805.g082f7c87e0-goog
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]