* [PATCH] xen/vpci: Fix msix existing mapping printk
@ 2025-04-23 21:22 Jason Andryuk
2025-04-23 21:32 ` Jason Andryuk
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jason Andryuk @ 2025-04-23 21:22 UTC (permalink / raw)
To: xen-devel; +Cc: Jason Andryuk, Roger Pau Monné
The format string lacks a space, so mfn and type run together:
(XEN) d0v0 0000:06:00.7: existing mapping (mfn: 753037type: 0) at 0x1 clobbers MSIX MMIO area
Add a space.
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
xen/drivers/vpci/msix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index f3804ce047..499810b238 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -666,7 +666,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
put_gfn(d, start);
gprintk(XENLOG_WARNING,
"%pp: existing mapping (mfn: %" PRI_mfn
- "type: %d) at %#lx clobbers MSIX MMIO area\n",
+ " type: %d) at %#lx clobbers MSIX MMIO area\n",
&pdev->sbdf, mfn_x(mfn), t, start);
return -EEXIST;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] xen/vpci: Fix msix existing mapping printk
2025-04-23 21:22 [PATCH] xen/vpci: Fix msix existing mapping printk Jason Andryuk
@ 2025-04-23 21:32 ` Jason Andryuk
2025-04-23 21:36 ` dmkhn
2025-04-24 6:18 ` Jan Beulich
2 siblings, 0 replies; 5+ messages in thread
From: Jason Andryuk @ 2025-04-23 21:32 UTC (permalink / raw)
To: xen-devel; +Cc: Roger Pau Monné
On 2025-04-23 17:22, Jason Andryuk wrote:
> The format string lacks a space, so mfn and type run together:
> (XEN) d0v0 0000:06:00.7: existing mapping (mfn: 753037type: 0) at 0x1 clobbers MSIX MMIO area
>
> Add a space.
>
Fixes: 677053fac17a ("vpci/msix: carve p2m hole for MSIX MMIO regions")
if we want one.
Regards,
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xen/vpci: Fix msix existing mapping printk
2025-04-23 21:22 [PATCH] xen/vpci: Fix msix existing mapping printk Jason Andryuk
2025-04-23 21:32 ` Jason Andryuk
@ 2025-04-23 21:36 ` dmkhn
2025-04-24 6:18 ` Jan Beulich
2 siblings, 0 replies; 5+ messages in thread
From: dmkhn @ 2025-04-23 21:36 UTC (permalink / raw)
To: Jason Andryuk; +Cc: xen-devel, Roger Pau Monné
On Wed, Apr 23, 2025 at 05:22:29PM -0400, Jason Andryuk wrote:
> The format string lacks a space, so mfn and type run together:
> (XEN) d0v0 0000:06:00.7: existing mapping (mfn: 753037type: 0) at 0x1 clobbers MSIX MMIO area
>
> Add a space.
>
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
Reviewed-by: Denis Mukhin <dmukhin@ford.com>
> ---
> xen/drivers/vpci/msix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
> index f3804ce047..499810b238 100644
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -666,7 +666,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
> put_gfn(d, start);
> gprintk(XENLOG_WARNING,
> "%pp: existing mapping (mfn: %" PRI_mfn
> - "type: %d) at %#lx clobbers MSIX MMIO area\n",
> + " type: %d) at %#lx clobbers MSIX MMIO area\n",
> &pdev->sbdf, mfn_x(mfn), t, start);
> return -EEXIST;
> }
> --
> 2.49.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen/vpci: Fix msix existing mapping printk
2025-04-23 21:22 [PATCH] xen/vpci: Fix msix existing mapping printk Jason Andryuk
2025-04-23 21:32 ` Jason Andryuk
2025-04-23 21:36 ` dmkhn
@ 2025-04-24 6:18 ` Jan Beulich
2025-04-24 14:03 ` Jason Andryuk
2 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2025-04-24 6:18 UTC (permalink / raw)
To: Jason Andryuk; +Cc: Roger Pau Monné, xen-devel
On 23.04.2025 23:22, Jason Andryuk wrote:
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -666,7 +666,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
> put_gfn(d, start);
> gprintk(XENLOG_WARNING,
> "%pp: existing mapping (mfn: %" PRI_mfn
> - "type: %d) at %#lx clobbers MSIX MMIO area\n",
> + " type: %d) at %#lx clobbers MSIX MMIO area\n",
Imo this is a good indication that the format string better wouldn't be
extending across multiple lines. Then it would also be possible to grep
for it (in the sources) using e.g. "existing mapping .* clobbers".
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen/vpci: Fix msix existing mapping printk
2025-04-24 6:18 ` Jan Beulich
@ 2025-04-24 14:03 ` Jason Andryuk
0 siblings, 0 replies; 5+ messages in thread
From: Jason Andryuk @ 2025-04-24 14:03 UTC (permalink / raw)
To: Jan Beulich; +Cc: Roger Pau Monné, xen-devel
On 2025-04-24 02:18, Jan Beulich wrote:
> On 23.04.2025 23:22, Jason Andryuk wrote:
>> --- a/xen/drivers/vpci/msix.c
>> +++ b/xen/drivers/vpci/msix.c
>> @@ -666,7 +666,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
>> put_gfn(d, start);
>> gprintk(XENLOG_WARNING,
>> "%pp: existing mapping (mfn: %" PRI_mfn
>> - "type: %d) at %#lx clobbers MSIX MMIO area\n",
>> + " type: %d) at %#lx clobbers MSIX MMIO area\n",
>
> Imo this is a good indication that the format string better wouldn't be
> extending across multiple lines. Then it would also be possible to grep
> for it (in the sources) using e.g. "existing mapping .* clobbers".
Sure, a single line works for me.
Thanks,
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-24 14:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 21:22 [PATCH] xen/vpci: Fix msix existing mapping printk Jason Andryuk
2025-04-23 21:32 ` Jason Andryuk
2025-04-23 21:36 ` dmkhn
2025-04-24 6:18 ` Jan Beulich
2025-04-24 14:03 ` Jason Andryuk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.