All of lore.kernel.org
 help / color / mirror / Atom feed
From: dmkhn@proton.me
To: Jason Andryuk <jason.andryuk@amd.com>
Cc: xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@vates.tech>
Subject: Re: [PATCH 2/2] tools/xen-hptool: Replace hard tabs
Date: Wed, 23 Apr 2025 21:38:16 +0000	[thread overview]
Message-ID: <aAldxUIrieS25eoM@kraken> (raw)
In-Reply-To: <20250423212821.42776-3-jason.andryuk@amd.com>

On Wed, Apr 23, 2025 at 05:28:21PM -0400, Jason Andryuk wrote:
> With a tab stop of 8, the alignment is off.  Replace the hard tabs with
> spaces to match the file.
> 
> Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces")
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>

Reviewed-by: Denis Mukhin <dmukhin@ford.com>

> ---
>  tools/misc/xen-hptool.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c
> index d850404e31..590810b6eb 100644
> --- a/tools/misc/xen-hptool.c
> +++ b/tools/misc/xen-hptool.c
> @@ -56,7 +56,7 @@ static int hp_mem_online_func(int argc, char *argv[])
>          fprintf(stderr, "Onlining page mfn %lx is broken, "
>                          "Memory online failed\n", mfn);
>          ret = -1;
> -	}
> +    }
>      else if (status & PG_ONLINE_ONLINED)
>          printf("Memory mfn %lx onlined successfully\n", mfn);
>      else
> @@ -85,14 +85,14 @@ static int hp_mem_query_func(int argc, char *argv[])
>          fprintf(stderr, "Querying page mfn %lx failed, error %x\n", mfn, errno);
>      else
>      {
> -		printf("Memory Status %x: [", status);
> +        printf("Memory Status %x: [", status);
>          if ( status & PG_OFFLINE_STATUS_OFFLINE_PENDING)
>              printf(" PAGE_OFFLINE_PENDING ");
>          if ( status & PG_OFFLINE_STATUS_BROKEN )
>              printf(" PAGE_BROKEND  ");
>          if ( status & PG_OFFLINE_STATUS_OFFLINED )
>              printf(" PAGE_OFFLINED ");
> -		else
> +        else
>              printf(" PAGE_ONLINED ");
>          printf("]\n");
>      }
> --
> 2.49.0
> 
> 



  reply	other threads:[~2025-04-23 21:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 21:28 [PATCH 0/2] xen-hptool small cleanups Jason Andryuk
2025-04-23 21:28 ` [PATCH 1/2] tools/xen-hptool: Add missing newlines Jason Andryuk
2025-04-23 21:37   ` dmkhn
2025-04-24 14:59   ` Anthony PERARD
2025-04-23 21:28 ` [PATCH 2/2] tools/xen-hptool: Replace hard tabs Jason Andryuk
2025-04-23 21:38   ` dmkhn [this message]
2025-04-24 15:00   ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAldxUIrieS25eoM@kraken \
    --to=dmkhn@proton.me \
    --cc=anthony.perard@vates.tech \
    --cc=jason.andryuk@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.