* [PATCH 0/2] xen-hptool small cleanups @ 2025-04-23 21:28 Jason Andryuk 2025-04-23 21:28 ` [PATCH 1/2] tools/xen-hptool: Add missing newlines Jason Andryuk 2025-04-23 21:28 ` [PATCH 2/2] tools/xen-hptool: Replace hard tabs Jason Andryuk 0 siblings, 2 replies; 7+ messages in thread From: Jason Andryuk @ 2025-04-23 21:28 UTC (permalink / raw) To: xen-devel; +Cc: Jason Andryuk, Anthony PERARD Two small cleanups for xen-hptool. Jason Andryuk (2): tools/xen-hptool: Add missing newlines tools/xen-hptool: Replace hard tabs tools/misc/xen-hptool.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.49.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] tools/xen-hptool: Add missing newlines 2025-04-23 21:28 [PATCH 0/2] xen-hptool small cleanups Jason Andryuk @ 2025-04-23 21:28 ` Jason Andryuk 2025-04-23 21:37 ` dmkhn 2025-04-24 14:59 ` Anthony PERARD 2025-04-23 21:28 ` [PATCH 2/2] tools/xen-hptool: Replace hard tabs Jason Andryuk 1 sibling, 2 replies; 7+ messages in thread From: Jason Andryuk @ 2025-04-23 21:28 UTC (permalink / raw) To: xen-devel; +Cc: Jason Andryuk, Anthony PERARD Add some missing newlines to error messages. Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces") Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> --- tools/misc/xen-hptool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c index 6d6aec8bad..d850404e31 100644 --- a/tools/misc/xen-hptool.c +++ b/tools/misc/xen-hptool.c @@ -51,7 +51,7 @@ static int hp_mem_online_func(int argc, char *argv[]) ret = xc_mark_page_online(xch, mfn, mfn, &status); if (ret < 0) - fprintf(stderr, "Onlining page mfn %lx failed, error %x", mfn, errno); + fprintf(stderr, "Onlining page mfn %lx failed, error %x\n", mfn, errno); else if (status & (PG_ONLINE_FAILED |PG_ONLINE_BROKEN)) { fprintf(stderr, "Onlining page mfn %lx is broken, " "Memory online failed\n", mfn); @@ -82,7 +82,7 @@ static int hp_mem_query_func(int argc, char *argv[]) ret = xc_query_page_offline_status(xch, mfn, mfn, &status); if (ret < 0) - fprintf(stderr, "Querying page mfn %lx failed, error %x", mfn, errno); + fprintf(stderr, "Querying page mfn %lx failed, error %x\n", mfn, errno); else { printf("Memory Status %x: [", status); -- 2.49.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] tools/xen-hptool: Add missing newlines 2025-04-23 21:28 ` [PATCH 1/2] tools/xen-hptool: Add missing newlines Jason Andryuk @ 2025-04-23 21:37 ` dmkhn 2025-04-24 14:59 ` Anthony PERARD 1 sibling, 0 replies; 7+ messages in thread From: dmkhn @ 2025-04-23 21:37 UTC (permalink / raw) To: Jason Andryuk; +Cc: xen-devel, Anthony PERARD On Wed, Apr 23, 2025 at 05:28:20PM -0400, Jason Andryuk wrote: > Add some missing newlines to error messages. > > Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces") > Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> Reviewed-by: Denis Mukhin <dmukhin@ford.com> > --- > tools/misc/xen-hptool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c > index 6d6aec8bad..d850404e31 100644 > --- a/tools/misc/xen-hptool.c > +++ b/tools/misc/xen-hptool.c > @@ -51,7 +51,7 @@ static int hp_mem_online_func(int argc, char *argv[]) > ret = xc_mark_page_online(xch, mfn, mfn, &status); > > if (ret < 0) > - fprintf(stderr, "Onlining page mfn %lx failed, error %x", mfn, errno); > + fprintf(stderr, "Onlining page mfn %lx failed, error %x\n", mfn, errno); > else if (status & (PG_ONLINE_FAILED |PG_ONLINE_BROKEN)) { > fprintf(stderr, "Onlining page mfn %lx is broken, " > "Memory online failed\n", mfn); > @@ -82,7 +82,7 @@ static int hp_mem_query_func(int argc, char *argv[]) > ret = xc_query_page_offline_status(xch, mfn, mfn, &status); > > if (ret < 0) > - fprintf(stderr, "Querying page mfn %lx failed, error %x", mfn, errno); > + fprintf(stderr, "Querying page mfn %lx failed, error %x\n", mfn, errno); > else > { > printf("Memory Status %x: [", status); > -- > 2.49.0 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] tools/xen-hptool: Add missing newlines 2025-04-23 21:28 ` [PATCH 1/2] tools/xen-hptool: Add missing newlines Jason Andryuk 2025-04-23 21:37 ` dmkhn @ 2025-04-24 14:59 ` Anthony PERARD 1 sibling, 0 replies; 7+ messages in thread From: Anthony PERARD @ 2025-04-24 14:59 UTC (permalink / raw) To: Jason Andryuk; +Cc: xen-devel, Anthony PERARD On Wed, Apr 23, 2025 at 05:28:20PM -0400, Jason Andryuk wrote: > Add some missing newlines to error messages. > > Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces") > Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> Acked-by: Anthony PERARD <anthony.perard@vates.tech> Thanks, -- Anthony PERARD ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] tools/xen-hptool: Replace hard tabs 2025-04-23 21:28 [PATCH 0/2] xen-hptool small cleanups Jason Andryuk 2025-04-23 21:28 ` [PATCH 1/2] tools/xen-hptool: Add missing newlines Jason Andryuk @ 2025-04-23 21:28 ` Jason Andryuk 2025-04-23 21:38 ` dmkhn 2025-04-24 15:00 ` Anthony PERARD 1 sibling, 2 replies; 7+ messages in thread From: Jason Andryuk @ 2025-04-23 21:28 UTC (permalink / raw) To: xen-devel; +Cc: Jason Andryuk, Anthony PERARD With a tab stop of 8, the alignment is off. Replace the hard tabs with spaces to match the file. Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces") Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> --- tools/misc/xen-hptool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c index d850404e31..590810b6eb 100644 --- a/tools/misc/xen-hptool.c +++ b/tools/misc/xen-hptool.c @@ -56,7 +56,7 @@ static int hp_mem_online_func(int argc, char *argv[]) fprintf(stderr, "Onlining page mfn %lx is broken, " "Memory online failed\n", mfn); ret = -1; - } + } else if (status & PG_ONLINE_ONLINED) printf("Memory mfn %lx onlined successfully\n", mfn); else @@ -85,14 +85,14 @@ static int hp_mem_query_func(int argc, char *argv[]) fprintf(stderr, "Querying page mfn %lx failed, error %x\n", mfn, errno); else { - printf("Memory Status %x: [", status); + printf("Memory Status %x: [", status); if ( status & PG_OFFLINE_STATUS_OFFLINE_PENDING) printf(" PAGE_OFFLINE_PENDING "); if ( status & PG_OFFLINE_STATUS_BROKEN ) printf(" PAGE_BROKEND "); if ( status & PG_OFFLINE_STATUS_OFFLINED ) printf(" PAGE_OFFLINED "); - else + else printf(" PAGE_ONLINED "); printf("]\n"); } -- 2.49.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] tools/xen-hptool: Replace hard tabs 2025-04-23 21:28 ` [PATCH 2/2] tools/xen-hptool: Replace hard tabs Jason Andryuk @ 2025-04-23 21:38 ` dmkhn 2025-04-24 15:00 ` Anthony PERARD 1 sibling, 0 replies; 7+ messages in thread From: dmkhn @ 2025-04-23 21:38 UTC (permalink / raw) To: Jason Andryuk; +Cc: xen-devel, Anthony PERARD On Wed, Apr 23, 2025 at 05:28:21PM -0400, Jason Andryuk wrote: > With a tab stop of 8, the alignment is off. Replace the hard tabs with > spaces to match the file. > > Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces") > Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> Reviewed-by: Denis Mukhin <dmukhin@ford.com> > --- > tools/misc/xen-hptool.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c > index d850404e31..590810b6eb 100644 > --- a/tools/misc/xen-hptool.c > +++ b/tools/misc/xen-hptool.c > @@ -56,7 +56,7 @@ static int hp_mem_online_func(int argc, char *argv[]) > fprintf(stderr, "Onlining page mfn %lx is broken, " > "Memory online failed\n", mfn); > ret = -1; > - } > + } > else if (status & PG_ONLINE_ONLINED) > printf("Memory mfn %lx onlined successfully\n", mfn); > else > @@ -85,14 +85,14 @@ static int hp_mem_query_func(int argc, char *argv[]) > fprintf(stderr, "Querying page mfn %lx failed, error %x\n", mfn, errno); > else > { > - printf("Memory Status %x: [", status); > + printf("Memory Status %x: [", status); > if ( status & PG_OFFLINE_STATUS_OFFLINE_PENDING) > printf(" PAGE_OFFLINE_PENDING "); > if ( status & PG_OFFLINE_STATUS_BROKEN ) > printf(" PAGE_BROKEND "); > if ( status & PG_OFFLINE_STATUS_OFFLINED ) > printf(" PAGE_OFFLINED "); > - else > + else > printf(" PAGE_ONLINED "); > printf("]\n"); > } > -- > 2.49.0 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] tools/xen-hptool: Replace hard tabs 2025-04-23 21:28 ` [PATCH 2/2] tools/xen-hptool: Replace hard tabs Jason Andryuk 2025-04-23 21:38 ` dmkhn @ 2025-04-24 15:00 ` Anthony PERARD 1 sibling, 0 replies; 7+ messages in thread From: Anthony PERARD @ 2025-04-24 15:00 UTC (permalink / raw) To: Jason Andryuk; +Cc: xen-devel, Anthony PERARD On Wed, Apr 23, 2025 at 05:28:21PM -0400, Jason Andryuk wrote: > With a tab stop of 8, the alignment is off. Replace the hard tabs with > spaces to match the file. > > Fixes: 284d5633be37 ("Tools: add online/offline hotplug user interfaces") > Signed-off-by: Jason Andryuk <jason.andryuk@amd.com> Acked-by: Anthony PERARD <anthony.perard@vates.tech> Thanks, -- Anthony PERARD ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-04-24 15:00 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-04-23 21:28 [PATCH 0/2] xen-hptool small cleanups Jason Andryuk 2025-04-23 21:28 ` [PATCH 1/2] tools/xen-hptool: Add missing newlines Jason Andryuk 2025-04-23 21:37 ` dmkhn 2025-04-24 14:59 ` Anthony PERARD 2025-04-23 21:28 ` [PATCH 2/2] tools/xen-hptool: Replace hard tabs Jason Andryuk 2025-04-23 21:38 ` dmkhn 2025-04-24 15:00 ` Anthony PERARD
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.