From: Patrick Steinhardt <ps@pks.im>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org, Peter Seiderer <ps.report@gmx.net>
Subject: Re: [PATCH 2/2] meson: prefer POSIX-specified shell path
Date: Fri, 25 Apr 2025 07:21:29 +0200 [thread overview]
Message-ID: <aAsb2SEbxatCw9Zs@pks.im> (raw)
In-Reply-To: <m2egcx4i2nezlwlyioofnz4srjgbyhb4dkyrpi5crnt5uwuvy3@a7tbji5lrnvn>
On Thu, Apr 24, 2025 at 03:18:29PM -0500, Justin Tobler wrote:
> On 25/04/24 03:38PM, Patrick Steinhardt wrote:
> > diff --git a/meson.build b/meson.build
> > index 8f04534c7ff..1db768380bd 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -236,7 +236,7 @@ sed = find_program('sed', dirs: program_path, native: true)
> > shell = find_program('sh', dirs: program_path, native: true)
> > tar = find_program('tar', dirs: program_path, native: true)
> >
> > -target_shell = find_program('sh', dirs: program_path, native: false)
> > +target_shell = find_program('sh', dirs: program_path + [ '/bin' ], native: false)
>
> It might be nice to leave a comment explaining the ordering intent.
Will do.
Patrick
next prev parent reply other threads:[~2025-04-25 5:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 13:38 [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Patrick Steinhardt
2025-04-24 13:38 ` [PATCH 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25 0:45 ` Eli Schwartz
2025-04-25 5:21 ` Patrick Steinhardt
2025-04-25 16:34 ` Junio C Hamano
2025-04-24 13:38 ` [PATCH 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-24 20:18 ` Justin Tobler
2025-04-25 5:21 ` Patrick Steinhardt [this message]
2025-04-24 18:28 ` [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-04-25 5:21 ` Patrick Steinhardt
2025-04-25 5:47 ` [PATCH v2 " Patrick Steinhardt
2025-04-25 5:47 ` [PATCH v2 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25 8:27 ` Toon Claes
2025-04-25 5:47 ` [PATCH v2 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-25 8:35 ` Toon Claes
2025-04-25 10:49 ` brian m. carlson
2025-04-25 11:52 ` Patrick Steinhardt
2025-04-25 11:24 ` [PATCH v2 0/2] meson: prefer '/bin/sh' over PATH lookup Toon Claes
2025-04-25 14:11 ` [PATCH v3 " Patrick Steinhardt
2025-04-25 14:11 ` [PATCH v3 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25 14:11 ` [PATCH v3 2/2] meson: prefer shell at "/bin/sh" Patrick Steinhardt
2025-04-25 17:04 ` Junio C Hamano
2025-04-25 18:07 ` Eli Schwartz
2025-04-25 18:51 ` Junio C Hamano
2025-04-25 22:21 ` Eli Schwartz
2025-04-25 20:10 ` brian m. carlson
2025-04-25 22:25 ` Eli Schwartz
2025-04-25 20:13 ` brian m. carlson
2025-05-02 21:16 ` [PATCH v3 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-05-02 22:37 ` Eli Schwartz
2025-05-05 6:08 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAsb2SEbxatCw9Zs@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.