From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: do_setup(): Check for supported arch first
Date: Tue, 29 Apr 2025 17:06:16 +0200 [thread overview]
Message-ID: <aBDq6PobtIDF2_nV@yuki.lan> (raw)
In-Reply-To: <6d9e6e5c-2453-4f81-add3-01c193776e7e@suse.com>
Hi!
> I guess the reason is that we want to skip code which is not compiling
> for our architecture, right?
> But do we already have TST_TEST_CONF, so I'm a bit puzzled on the use case.
The problem here is that with TST_TEST_TCONF() the supported architecture
is not exported into the metadata.
There are two cases where TST_TEST_TCONF() is used in LTP:
- usupported architecture for the test
- missing headers during compilation
The first case should ideally be converted so that we have the supported
architectures in the test metadata.
Another option is just to add metadata to the tst_test structure and
keep TST_TEST_TCONF(), but I do not like that solution, because the
ifdefs and .supported_archs can go out of sync easily because tst_test
structure is not used when TST_TEST_TCONF() is used.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-04-29 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 13:55 [LTP] [PATCH] lib: do_setup(): Check for supported arch first Cyril Hrubis
2025-04-29 14:55 ` Andrea Cervesato via ltp
2025-04-29 15:06 ` Cyril Hrubis [this message]
2025-04-29 15:17 ` Andrea Cervesato via ltp
2025-04-29 15:20 ` Cyril Hrubis
2025-04-29 15:29 ` Andrea Cervesato via ltp
2025-04-29 21:22 ` Petr Vorel
2025-04-30 7:14 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBDq6PobtIDF2_nV@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.