Re: [LTP] [PATCH] lib: do_setup(): Check for supported arch first

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > This commit moves the check for supported architecture before the check
> > for test function existence. This allows us do ifdef out the run
> > function pointer initialization and properly TCONF on unsupported
> > platform.
> 
> LGTM. Ideally could you also convert some test (as example which others
> can follow - like they do for docparse fixes).
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> > Example usage:
> 
> >  #include "tst_test.h"
> 
> >  #ifdef __x86_64__
> I would personally did not bother with #ifdef, but it's true it makes resulted
> binary smaller (for non-intel arch).

It's not about tinification, it's usually that there is inline assembly
that cannot be compiled at all...

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp