* [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat
@ 2025-04-30 2:52 Lu Baolu
2025-04-30 9:01 ` Tian, Kevin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lu Baolu @ 2025-04-30 2:52 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Robin Murphy; +Cc: iommu, linux-kernel, Lu Baolu
The dev_enable/disable_feat ops have been removed by commit
<f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()").
Cleanup the comments to make the code clean.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/iommu.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 1785caee5977..36df38c2d3a9 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -590,8 +590,6 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size,
* @of_xlate: add OF master IDs to iommu grouping
* @is_attach_deferred: Check if domain attach should be deferred from iommu
* driver init to device driver init (default no)
- * @dev_enable/disable_feat: per device entries to enable/disable
- * iommu specific features.
* @page_response: handle page request response
* @def_domain_type: device default domain type, return value:
* - IOMMU_DOMAIN_IDENTITY: must use an identity domain
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat
2025-04-30 2:52 [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat Lu Baolu
@ 2025-04-30 9:01 ` Tian, Kevin
2025-04-30 10:32 ` Vasant Hegde
2025-05-02 6:42 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Tian, Kevin @ 2025-04-30 9:01 UTC (permalink / raw)
To: Lu Baolu, Joerg Roedel, Will Deacon, Robin Murphy
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Wednesday, April 30, 2025 10:53 AM
>
> The dev_enable/disable_feat ops have been removed by commit
> <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()").
> Cleanup the comments to make the code clean.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat
2025-04-30 2:52 [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat Lu Baolu
2025-04-30 9:01 ` Tian, Kevin
@ 2025-04-30 10:32 ` Vasant Hegde
2025-05-02 6:42 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Vasant Hegde @ 2025-04-30 10:32 UTC (permalink / raw)
To: Lu Baolu, Joerg Roedel, Will Deacon, Robin Murphy; +Cc: iommu, linux-kernel
On 4/30/2025 8:22 AM, Lu Baolu wrote:
> The dev_enable/disable_feat ops have been removed by commit
> <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()").
> Cleanup the comments to make the code clean.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
> ---
> include/linux/iommu.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 1785caee5977..36df38c2d3a9 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -590,8 +590,6 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size,
> * @of_xlate: add OF master IDs to iommu grouping
> * @is_attach_deferred: Check if domain attach should be deferred from iommu
> * driver init to device driver init (default no)
> - * @dev_enable/disable_feat: per device entries to enable/disable
> - * iommu specific features.
> * @page_response: handle page request response
> * @def_domain_type: device default domain type, return value:
> * - IOMMU_DOMAIN_IDENTITY: must use an identity domain
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat
2025-04-30 2:52 [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat Lu Baolu
2025-04-30 9:01 ` Tian, Kevin
2025-04-30 10:32 ` Vasant Hegde
@ 2025-05-02 6:42 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2025-05-02 6:42 UTC (permalink / raw)
To: Lu Baolu; +Cc: Will Deacon, Robin Murphy, iommu, linux-kernel
On Wed, Apr 30, 2025 at 10:52:49AM +0800, Lu Baolu wrote:
> The dev_enable/disable_feat ops have been removed by commit
> <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()").
> Cleanup the comments to make the code clean.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> include/linux/iommu.h | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-02 6:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-30 2:52 [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat Lu Baolu
2025-04-30 9:01 ` Tian, Kevin
2025-04-30 10:32 ` Vasant Hegde
2025-05-02 6:42 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.