From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Mario Limonciello" <superm1@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Yazen Ghannam" <yazen.ghannam@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC"
<linux-i2c@vger.kernel.org>,
"open list:AMD PMC DRIVER" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v5 5/5] x86/CPU/AMD: Print the reason for the last reset
Date: Sun, 4 May 2025 08:38:29 +0200 [thread overview]
Message-ID: <aBcLZUxct4ppmWVB@gmail.com> (raw)
In-Reply-To: <20250501083151.GBaBMxdyrtpcVlQaei@fat_crate.local>
* Borislav Petkov <bp@alien8.de> wrote:
> + for (i = 0; i <= ARRAY_SIZE(s5_reset_reason_txt); i++) {
> + if (!(value & BIT(i)))
> continue;
>
> - nr_reasons++;
> - pr_info("x86/amd: Previous system reset reason [0x%08lx]: %s\n",
> - value, s5_reset_reason_txt[bit]);
> + if (s5_reset_reason_txt[i])
> + pr_info("x86/amd: Previous system reset reason [0x%08lx]: %s\n",
> + value, s5_reset_reason_txt[i]);
> }
Yeah, this is much more straightforward code that gets us all the
information - as diagnostics code should be.
Thanks,
Ingo
next prev parent reply other threads:[~2025-05-04 6:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 23:48 [PATCH v5 0/5] AMD Zen debugging documentation Mario Limonciello
2025-04-22 23:48 ` [PATCH v5 1/5] Documentation: Add AMD Zen debugging document Mario Limonciello
2025-05-02 9:36 ` [tip: x86/platform] " tip-bot2 for Mario Limonciello
2025-04-22 23:48 ` [PATCH v5 2/5] i2c: piix4: Depends on X86 Mario Limonciello
2025-04-24 16:24 ` [tip: x86/platform] i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86 tip-bot2 for Mario Limonciello
2025-04-25 11:18 ` [PATCH v5 2/5] i2c: piix4: Depends on X86 Andi Shyti
2025-04-26 9:42 ` Ingo Molnar
2025-04-28 18:18 ` Andi Shyti
2025-04-26 9:57 ` [tip: x86/platform] i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86 tip-bot2 for Mario Limonciello
2025-06-10 9:16 ` [PATCH v5 2/5] i2c: piix4: Depends on X86 Geert Uytterhoeven
2025-06-10 9:24 ` Huacai Chen
2025-06-10 14:12 ` Mario Limonciello
2025-06-10 14:53 ` Hans de Goede
2025-06-10 14:55 ` Hans de Goede
2025-06-10 16:59 ` Geert Uytterhoeven
2025-06-10 18:52 ` Hans de Goede
2025-04-22 23:48 ` [PATCH v5 3/5] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd/fch.h Mario Limonciello
2025-04-24 16:24 ` [tip: x86/platform] i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH definitions to <asm/amd/fch.h> tip-bot2 for Mario Limonciello
2025-04-25 11:18 ` [PATCH v5 3/5] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd/fch.h Andi Shyti
2025-04-26 9:57 ` [tip: x86/platform] i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH definitions to <asm/amd/fch.h> tip-bot2 for Mario Limonciello
2025-04-22 23:48 ` [PATCH v5 4/5] platform/x86/amd: pmc: use FCH_PM_BASE definition Mario Limonciello
2025-04-24 16:24 ` [tip: x86/platform] platform/x86/amd/pmc: Use " tip-bot2 for Mario Limonciello
2025-04-26 9:56 ` tip-bot2 for Mario Limonciello
2025-04-29 14:39 ` [PATCH v5 4/5] platform/x86/amd: pmc: use " Ilpo Järvinen
2025-04-22 23:48 ` [PATCH v5 5/5] x86/CPU/AMD: Print the reason for the last reset Mario Limonciello
2025-04-30 19:03 ` Borislav Petkov
2025-04-30 19:05 ` Mario Limonciello
2025-04-30 19:10 ` Borislav Petkov
2025-04-30 19:17 ` Mario Limonciello
2025-04-30 19:25 ` Borislav Petkov
2025-04-30 19:32 ` Mario Limonciello
2025-04-30 19:38 ` Borislav Petkov
2025-05-01 8:31 ` Borislav Petkov
2025-05-04 6:38 ` Ingo Molnar [this message]
2025-05-02 9:36 ` [tip: x86/platform] " tip-bot2 for Yazen Ghannam
2025-05-04 6:37 ` Ingo Molnar
2025-05-04 7:03 ` [PATCH] x86/CPU/AMD: Clean up the last-reset printing code a bit Ingo Molnar
2025-05-04 9:52 ` Borislav Petkov
2025-05-04 18:08 ` Mario Limonciello
2025-05-05 5:32 ` [tip: x86/platform] " tip-bot2 for Ingo Molnar
2025-05-05 14:12 ` [tip: x86/platform] x86/CPU/AMD: Print the reason for the last reset tip-bot2 for Yazen Ghannam
2025-04-23 15:02 ` [PATCH v5 0/5] AMD Zen debugging documentation Jonathan Corbet
2025-04-28 16:14 ` Mario Limonciello
2025-04-24 15:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBcLZUxct4ppmWVB@gmail.com \
--to=mingo@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.