All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2] ci(win+Meson): build in Release mode
Date: Mon, 5 May 2025 08:06:16 +0200	[thread overview]
Message-ID: <aBhVWMabOFYRUjvD@pks.im> (raw)
In-Reply-To: <pull.1908.v2.git.1746282346370.gitgitgadget@gmail.com>

On Sat, May 03, 2025 at 02:25:46PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>     Changes since v1:
>     
>      * Rewrote the commit message to reflect that this patch is still
>        needed, even if the symptom that originally motivated the patch was
>        addressed in a different manner, because it was merely a symptom of
>        the underlying root cause that CI builds should not let Visual C
>        build Git in debug mode.

Ok, makes sense. I think we should ideally address this issue
strategically, e.g. by getting rid of asserts completely in our
codebase. But for now I agree that we should just build Git in release
mode on Windows.

Thanks!

Patrick

  reply	other threads:[~2025-05-05  6:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 15:05 [PATCH] ci(win+Meson): build in Release mode, avoiding t7001-mv hangs Johannes Schindelin via GitGitGadget
2025-04-25 15:18 ` Junio C Hamano
2025-04-28  7:47   ` Patrick Steinhardt
2025-04-28 17:01     ` Junio C Hamano
2025-04-29 12:20       ` Patrick Steinhardt
2025-04-29 20:48         ` Junio C Hamano
2025-04-30  8:58           ` Patrick Steinhardt
2025-04-30 12:46             ` Patrick Steinhardt
2025-04-29 20:57 ` Kristoffer Haugsbakk
2025-05-03 14:25 ` [PATCH v2] ci(win+Meson): build in Release mode Johannes Schindelin via GitGitGadget
2025-05-05  6:06   ` Patrick Steinhardt [this message]
2025-05-05  7:27     ` Johannes Schindelin
2025-05-05  9:43       ` Patrick Steinhardt
2025-05-05 15:54         ` Junio C Hamano
2025-05-06  7:57           ` Patrick Steinhardt
2025-05-06  8:32             ` Johannes Schindelin
2025-05-08 18:19               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBhVWMabOFYRUjvD@pks.im \
    --to=ps@pks.im \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.