From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, lihongbo22@huawei.com,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion
Date: Wed, 7 May 2025 14:46:28 +0000 [thread overview]
Message-ID: <aBtyRFIrDU3IfQhV@google.com> (raw)
In-Reply-To: <25cb13c8-3123-4ee6-b0bc-b44f3039b6c1@redhat.com>
On 05/06, Eric Sandeen wrote:
> On 5/6/25 9:56 PM, Eric Sandeen wrote:
> > On 5/6/25 8:23 PM, Jaegeuk Kim wrote:
>
> ...
>
> >> What about:
> >> # mount -o loop,noextent_cache f2fsfile.img mnt
> >>
> >> In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options,
> >> 3) clear_opt since mask is set?
> >
> > Not sure what I'm missing, it seems to work properly here but I haven't
> > pulled your (slightly) modified patches yet:
> >
> > # mount -o loop,extent_cache f2fsfile.img mnt
> > # mount | grep -wo extent_cache
> > extent_cache
> > # umount mnt
> >
> > # mount -o loop,noextent_cache f2fsfile.img mnt
> > # mount | grep -wo noextent_cache
> > noextent_cache
> > #
> >
> > this looks right?
> >
> > I'll check your tree tomorrow, though it doesn't sound like you made many
> > changes.
>
> Hmm, I checked tonight and I see the same (correct?) behavior in your tree.
>
> >> And, device_aliasing check is still failing, since it does not understand
> >> test_opt(). Probably it's the only case?
>
> Again, in your tree (I had to use a git version of f2fs-tools to make device
> aliasing work - maybe time for a release?) ;)
>
> # mkfs.ext4 /dev/vdc
> # mkfs/mkfs.f2fs -c /dev/vdc@vdc.file /dev/vdb
> # mount -o noextent_cache /dev/vdb mnt
> # dmesg | tail -n 1
> [ 581.924604] F2FS-fs (vdb): device aliasing requires extent cache
> # mount -o extent_cache /dev/vdb mnt
> # mount | grep -wo extent_cache
> extent_cache
> #
I meant:
# mkfs/mkfs.f2fs -c /dev/vdc@vdc.file /dev/vdb
# mount /dev/vdb mnt
It's supposed to be successful, since extent_cache is enabled by default.
>
> Maybe you can show me exactly what's not working for you?
>
> -Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, chao@kernel.org,
lihongbo22@huawei.com
Subject: Re: [PATCH V3 0/7] f2fs: new mount API conversion
Date: Wed, 7 May 2025 14:46:28 +0000 [thread overview]
Message-ID: <aBtyRFIrDU3IfQhV@google.com> (raw)
In-Reply-To: <25cb13c8-3123-4ee6-b0bc-b44f3039b6c1@redhat.com>
On 05/06, Eric Sandeen wrote:
> On 5/6/25 9:56 PM, Eric Sandeen wrote:
> > On 5/6/25 8:23 PM, Jaegeuk Kim wrote:
>
> ...
>
> >> What about:
> >> # mount -o loop,noextent_cache f2fsfile.img mnt
> >>
> >> In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options,
> >> 3) clear_opt since mask is set?
> >
> > Not sure what I'm missing, it seems to work properly here but I haven't
> > pulled your (slightly) modified patches yet:
> >
> > # mount -o loop,extent_cache f2fsfile.img mnt
> > # mount | grep -wo extent_cache
> > extent_cache
> > # umount mnt
> >
> > # mount -o loop,noextent_cache f2fsfile.img mnt
> > # mount | grep -wo noextent_cache
> > noextent_cache
> > #
> >
> > this looks right?
> >
> > I'll check your tree tomorrow, though it doesn't sound like you made many
> > changes.
>
> Hmm, I checked tonight and I see the same (correct?) behavior in your tree.
>
> >> And, device_aliasing check is still failing, since it does not understand
> >> test_opt(). Probably it's the only case?
>
> Again, in your tree (I had to use a git version of f2fs-tools to make device
> aliasing work - maybe time for a release?) ;)
>
> # mkfs.ext4 /dev/vdc
> # mkfs/mkfs.f2fs -c /dev/vdc@vdc.file /dev/vdb
> # mount -o noextent_cache /dev/vdb mnt
> # dmesg | tail -n 1
> [ 581.924604] F2FS-fs (vdb): device aliasing requires extent cache
> # mount -o extent_cache /dev/vdb mnt
> # mount | grep -wo extent_cache
> extent_cache
> #
I meant:
# mkfs/mkfs.f2fs -c /dev/vdc@vdc.file /dev/vdb
# mount /dev/vdb mnt
It's supposed to be successful, since extent_cache is enabled by default.
>
> Maybe you can show me exactly what's not working for you?
>
> -Eric
next prev parent reply other threads:[~2025-05-07 14:47 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 17:08 [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 1/7] f2fs: Add fs parameter specifications for mount options Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-08 2:40 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-08 2:40 ` Hongbo Li
2025-05-08 5:24 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 5:24 ` Chao Yu
2025-07-11 16:30 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-07-11 16:30 ` patchwork-bot+f2fs
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 2/7] f2fs: move the option parser into handle_mount_opt Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-06 20:24 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-06 20:24 ` Jaegeuk Kim
2025-05-08 5:30 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 5:30 ` Chao Yu
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 3/7] f2fs: Allow sbi to be NULL in f2fs_printk Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-08 5:30 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 5:30 ` Chao Yu
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 4/7] f2fs: Add f2fs_fs_context to record the mount options Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-08 6:34 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 6:34 ` Chao Yu
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 5/7] f2fs: separate the options parsing and options checking Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-06 22:01 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-06 22:01 ` Jaegeuk Kim
2025-05-06 22:52 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-06 22:52 ` Eric Sandeen
2025-05-06 23:30 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-06 23:30 ` Jaegeuk Kim
2025-05-08 8:13 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 8:13 ` Chao Yu
2025-05-08 15:52 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-08 15:52 ` Eric Sandeen
2025-05-08 22:11 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-12 3:59 ` Chao Yu via Linux-f2fs-devel
2025-05-12 3:32 ` Chao Yu via Linux-f2fs-devel
2025-05-12 3:32 ` Chao Yu
2025-05-14 1:10 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-14 1:10 ` Hongbo Li
2025-05-14 1:03 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-14 1:03 ` Hongbo Li
2025-05-13 2:15 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-13 2:15 ` Jaegeuk Kim
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 6/7] f2fs: introduce fs_context_operation structure Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-08 8:14 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 8:14 ` Chao Yu
2025-04-23 17:08 ` [f2fs-dev] [PATCH V3 7/7] f2fs: switch to the new mount api Eric Sandeen via Linux-f2fs-devel
2025-04-23 17:08 ` Eric Sandeen
2025-05-08 9:19 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-08 9:19 ` Chao Yu
2025-05-08 15:59 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-08 15:59 ` Eric Sandeen
2025-05-12 3:43 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-12 3:43 ` Chao Yu
2025-05-13 2:19 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-13 2:19 ` Eric Sandeen
2025-05-13 2:48 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-13 2:48 ` Chao Yu
2025-05-13 15:36 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-13 15:36 ` Jaegeuk Kim
2025-05-13 8:59 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-13 8:59 ` Chao Yu
2025-05-14 2:33 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-14 2:33 ` Hongbo Li
2025-05-14 4:03 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-14 4:03 ` Chao Yu
2025-05-14 6:15 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-14 6:15 ` Hongbo Li
2025-05-14 15:30 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-14 15:30 ` Jaegeuk Kim
2025-05-14 15:46 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-14 15:46 ` Eric Sandeen
2025-05-15 1:17 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-15 1:17 ` Hongbo Li
2025-05-16 2:01 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-16 2:01 ` Hongbo Li
2025-05-16 17:35 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-16 17:35 ` Jaegeuk Kim
2025-05-19 2:38 ` [f2fs-dev] " Hongbo Li via Linux-f2fs-devel
2025-05-19 2:38 ` Hongbo Li
2025-05-13 16:11 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-13 16:11 ` Jaegeuk Kim
2025-05-06 2:18 ` [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion Eric Sandeen via Linux-f2fs-devel
2025-05-06 2:18 ` Eric Sandeen
2025-05-06 16:02 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-06 16:02 ` Jaegeuk Kim
2025-05-06 22:53 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-06 22:53 ` Eric Sandeen
2025-05-06 23:55 ` [f2fs-dev] " Ian Kent
2025-05-06 23:55 ` Ian Kent
2025-05-07 0:35 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-07 0:35 ` Jaegeuk Kim
2025-05-07 0:51 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-07 0:51 ` Eric Sandeen
2025-05-07 1:23 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-07 1:23 ` Jaegeuk Kim
2025-05-07 2:56 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-07 2:56 ` Eric Sandeen
2025-05-07 3:45 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-07 3:45 ` Eric Sandeen
2025-05-07 14:46 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-05-07 14:46 ` Jaegeuk Kim
2025-05-07 17:11 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-07 17:11 ` Eric Sandeen
2025-05-07 19:48 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-07 19:48 ` Jaegeuk Kim
2025-05-07 20:19 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-07 20:19 ` Eric Sandeen
2025-05-07 20:28 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-07 20:28 ` Jaegeuk Kim
2025-05-07 20:46 ` [f2fs-dev] " Eric Sandeen via Linux-f2fs-devel
2025-05-07 20:46 ` Eric Sandeen
2025-05-07 21:36 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-05-07 21:36 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBtyRFIrDU3IfQhV@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=jaegeuk@kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.