From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH 2/2] block: avoid unnecessary queue freeze in elevator_set_none()
Date: Thu, 8 May 2025 11:57:09 +0800 [thread overview]
Message-ID: <aBwrlQuvlBVPGb5Y@fedora> (raw)
In-Reply-To: <20250507135450.GB1019@lst.de>
On Wed, May 07, 2025 at 03:54:50PM +0200, Christoph Hellwig wrote:
> On Wed, May 07, 2025 at 08:04:03PM +0800, Ming Lei wrote:
> > elevator_set_none() is called when deleting disk, in which queue has been
> > un-registered, and elevator switch can't happen any more.
> >
> > So if q->elevator is NULL, it is not necessary to freeze queue and drain
> > IO any more.
>
> Yes. Also if the disk owns the queue there can't be any more I/O per
> definition, so maybe check for that as well?
Not sure if I get your point, do you want to avoid freeze queue for the case
of disk owning the queue? I think it can't be done, because someone may
still open the bdev and submit IO to it even though del_gendisk() is
in-progress.
Thanks,
Ming
next prev parent reply other threads:[~2025-05-08 3:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 12:04 [PATCH 0/2] block: fix hang in elevator_change() and improve elevator_set_none Ming Lei
2025-05-07 12:04 ` [PATCH 1/2] block: move queue quiesce into elevator_change() Ming Lei
2025-05-07 13:53 ` Christoph Hellwig
2025-05-07 14:28 ` Ming Lei
2025-05-07 14:48 ` Ming Lei
2025-05-07 19:05 ` Nilay Shroff
2025-05-08 3:02 ` Ming Lei
2025-05-08 5:03 ` Christoph Hellwig
2025-05-08 8:03 ` Ming Lei
2025-05-07 12:04 ` [PATCH 2/2] block: avoid unnecessary queue freeze in elevator_set_none() Ming Lei
2025-05-07 13:54 ` Christoph Hellwig
2025-05-08 3:57 ` Ming Lei [this message]
2025-05-08 5:04 ` Christoph Hellwig
2025-05-08 8:16 ` Ming Lei
2025-05-07 19:20 ` Nilay Shroff
2025-05-08 4:31 ` [PATCH 0/2] block: fix hang in elevator_change() and improve elevator_set_none Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBwrlQuvlBVPGb5Y@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.