All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH 2/2] block: avoid unnecessary queue freeze in elevator_set_none()
Date: Thu, 8 May 2025 16:16:25 +0800	[thread overview]
Message-ID: <aBxoWUETFToLLzCN@fedora> (raw)
In-Reply-To: <20250508050448.GB27049@lst.de>

On Thu, May 08, 2025 at 07:04:48AM +0200, Christoph Hellwig wrote:
> On Thu, May 08, 2025 at 11:57:09AM +0800, Ming Lei wrote:
> > Not sure if I get your point, do you want to avoid freeze queue for the case
> > of disk owning the queue? I think it can't be done, because someone may
> > still open the bdev and submit IO to it even though del_gendisk() is
> > in-progress.
> 
> Isn't the disk marked dead at this point and there should be no
> pending I/O submissions?

Yeah, just inflight IOs aren't drained.

This patch isn't necessary, the only effect is that blk_mq_freeze_queue_wait
is done a bit earlier.


Thanks, 
Ming


  reply	other threads:[~2025-05-08  8:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 12:04 [PATCH 0/2] block: fix hang in elevator_change() and improve elevator_set_none Ming Lei
2025-05-07 12:04 ` [PATCH 1/2] block: move queue quiesce into elevator_change() Ming Lei
2025-05-07 13:53   ` Christoph Hellwig
2025-05-07 14:28     ` Ming Lei
2025-05-07 14:48       ` Ming Lei
2025-05-07 19:05       ` Nilay Shroff
2025-05-08  3:02         ` Ming Lei
2025-05-08  5:03       ` Christoph Hellwig
2025-05-08  8:03         ` Ming Lei
2025-05-07 12:04 ` [PATCH 2/2] block: avoid unnecessary queue freeze in elevator_set_none() Ming Lei
2025-05-07 13:54   ` Christoph Hellwig
2025-05-08  3:57     ` Ming Lei
2025-05-08  5:04       ` Christoph Hellwig
2025-05-08  8:16         ` Ming Lei [this message]
2025-05-07 19:20   ` Nilay Shroff
2025-05-08  4:31 ` [PATCH 0/2] block: fix hang in elevator_change() and improve elevator_set_none Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBxoWUETFToLLzCN@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.