Re: [PATCH v6 2/6] soc: spacemit: create a header for clock/reset registers

From: Haylen Chu <heylenay@4d2.org>
To: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	p.zabel@pengutronix.de, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
	dlan@gentoo.org
Cc: inochiama@outlook.com, guodong@riscstar.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/6] soc: spacemit: create a header for clock/reset registers
Date: Thu, 8 May 2025 04:16:05 +0000	[thread overview]
Message-ID: <aBwwBSfnkw6XUOLA@ketchup> (raw)
In-Reply-To: <20250506210638.2800228-3-elder@riscstar.com>

On Tue, May 06, 2025 at 04:06:33PM -0500, Alex Elder wrote:
> Move the definitions of register offsets and fields used by the SpacemiT
> K1 SoC CCUs into a separate header file, so that they can be shared by
> the reset driver that will be found under drivers/reset.
> 
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
>  drivers/clk/spacemit/ccu-k1.c | 111 +--------------------------------
>  include/soc/spacemit/ccu_k1.h | 113 ++++++++++++++++++++++++++++++++++

CCU is abbreviated from "clock controller unit" thus the filename seems
a little strange to me. Will k1-syscon.h be a better name? We could put
all syscon registers together when introducing the power-domain driver
later, which could provide an overall view of register layout.

>  2 files changed, 114 insertions(+), 110 deletions(-)
>  create mode 100644 include/soc/spacemit/ccu_k1.h

Best regards,
Haylen Chu