From: dmkhn@proton.me
To: Jan Beulich <jbeulich@suse.com>
Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech,
julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()
Date: Tue, 20 May 2025 22:38:33 +0000 [thread overview]
Message-ID: <aC0EYzZgzCfOovVL@kraken> (raw)
In-Reply-To: <e13d061a-16ee-4b8d-8d4a-db1bba609bdf@suse.com>
On Tue, May 20, 2025 at 05:24:33PM +0200, Jan Beulich wrote:
> On 16.05.2025 04:29, dmkhn@proton.me wrote:
> > --- a/xen/arch/x86/include/asm/domain.h
> > +++ b/xen/arch/x86/include/asm/domain.h
> > @@ -494,6 +494,12 @@ struct arch_domain
> > X86_EMU_PIT | X86_EMU_USE_PIRQ | \
> > X86_EMU_VPCI)
> >
> > +/* User-selectable features. */
> > +#define X86_EMU_OPTIONAL (X86_EMU_USE_PIRQ)
> > +
> > +#define X86_EMU_BASELINE (X86_EMU_ALL & ~(X86_EMU_VPCI | \
> > + X86_EMU_OPTIONAL))
>
> That is, VPCI is neither baseline nor optional. Certainly at least strange.
IMO, X86_EMU_OPTIONAL should include both VPCI and PIRQ.
But that will be a behavior change: AFAIU, VPCI is injected implicitly for dom0
case only, "default" xl toolstack currently excludes VPCI for HVM domains.
Do I understand it correctly that "BASELINE" in the symbol name is a concern?
>
> Jan
next prev parent reply other threads:[~2025-05-20 22:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 2:29 [PATCH v2 0/2] xen/domain: updates to hardware emulation flags dmkhn
2025-05-16 2:29 ` [PATCH v2 1/2] xen/domain: introduce non-x86 " dmkhn
2025-05-20 15:21 ` Jan Beulich
2025-05-20 21:39 ` dmkhn
2025-05-21 6:01 ` Jan Beulich
2025-05-21 14:05 ` Roger Pau Monné
2025-05-28 21:17 ` dmkhn
2025-05-16 2:29 ` [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok() dmkhn
2025-05-20 15:24 ` Jan Beulich
2025-05-20 22:38 ` dmkhn [this message]
2025-05-20 23:00 ` Stefano Stabellini
2025-05-21 6:51 ` Jan Beulich
2025-05-21 6:04 ` Jan Beulich
2025-05-21 15:07 ` Roger Pau Monné
2025-05-22 0:26 ` dmkhn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC0EYzZgzCfOovVL@kraken \
--to=dmkhn@proton.me \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmukhin@ford.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.