Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

[Peter Xu <peterx@redhat.com>]

On Wed, May 21, 2025 at 08:43:37AM +0000, Zhijian Li (Fujitsu) wrote:
[...]
> > After this change, sample output (default, no "-a" specified):
> > 
> >    Status: postcopy-active
> >    Time (ms): total=40504, setup=14, down=145
> >    RAM info:
> >      Bandwidth (mbps): 6102.65
> >      Sizes (KB): psize=4, total=16777992
> >        transferred=37673019, remain=2136404,
> >        precopy=3, multifd=26108780, postcopy=11563855
> >      Pages: normal=9394288, zero=600672, rate_per_sec=185875
> >      Others: dirty_syncs=3, dirty_pages_rate=278378, postcopy_req=4078
> 
> (Feel free to ignore my comment if you have reached a consensus.)
> 
> Putting multiple fields in one line is a true need for human reading?

It definitely helps me but I agree that can be subjective.  So I'm happy to
collect opinions.

So my above layout was trying to leverage more on screens where width is
bigger than the height (which is pretty much the default).

> I don't have confident to reorg them so I feed this request to the AI,
> he suggested something like this:
> 
> Migration Status:
>    Status: completed
> 
> Time Statistics:
>    Setup: 15 ms
>    Downtime: 76 ms
>    Total: 122952 ms
> RAM Transfer:
>    Throughput: 8717.68 mbps
>    Page Size: 4 KB
>    Transferred:
>      Total: 130825923 KB
>      Precopied: 15 KB
>      Postcopied: 13691151 KB
>      Multifd: 117134260 KB
>    Remaining: 0 KB
>    Total RAM: 16777992 KB
> Page Statistics:
>    Normal Pages: 32622225
>    Zero Pages: 0
>    Duplicate Pages: 997263
>    Transfer Page Rate: 169431
>    Dirty Page Rate: 1234
>    Dirty Syncs: 10

I would trust you more than the AI, so feel free to share your opinion next
time (which won't hurt if it was a result of AI discussions, but only which
you agreed on :).

It's already in a pull, let's revisit whenever necessary.  Thanks for the
input!

-- 
Peter Xu