Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Peter Xu (peterx@redhat.com) wrote:
> On Wed, May 21, 2025 at 08:43:37AM +0000, Zhijian Li (Fujitsu) wrote:
> [...]
> > > After this change, sample output (default, no "-a" specified):
> > > 
> > >    Status: postcopy-active
> > >    Time (ms): total=40504, setup=14, down=145
> > >    RAM info:
> > >      Bandwidth (mbps): 6102.65
> > >      Sizes (KB): psize=4, total=16777992
> > >        transferred=37673019, remain=2136404,
> > >        precopy=3, multifd=26108780, postcopy=11563855
> > >      Pages: normal=9394288, zero=600672, rate_per_sec=185875
> > >      Others: dirty_syncs=3, dirty_pages_rate=278378, postcopy_req=4078
> > 
> > (Feel free to ignore my comment if you have reached a consensus.)
> > 
> > Putting multiple fields in one line is a true need for human reading?
> 
> It definitely helps me but I agree that can be subjective.  So I'm happy to
> collect opinions.
> 
> So my above layout was trying to leverage more on screens where width is
> bigger than the height (which is pretty much the default).

I think perhaps the problem with the on-one-line layout is that the grouping
is wrong;  grouping by unit probably doesn't make sense.

So it makes sense to me to have:
   Sizes: psize=4/KB
   Transfer: total=16777992 kB transferred=37673019 kB remain=11563855 kB
   Pages: normal=9394288 zero=600672
   Page rates: transferred=185875/s dirtied=278378/s
   Other: dirty_sync=3 postcopy_req=4078

so you have things on one line when you're comparing them - so it's easy
to see the transferred page/s is way less than the dirtied in this example
(really??)  because they're next to each other.
Or the 'Transfer' line is showing total, how much so far and how much remains

> > I don't have confident to reorg them so I feed this request to the AI,
> > he suggested something like this:
> > 
> > Migration Status:
> >    Status: completed
> > 
> > Time Statistics:
> >    Setup: 15 ms
> >    Downtime: 76 ms
> >    Total: 122952 ms
> > RAM Transfer:
> >    Throughput: 8717.68 mbps
> >    Page Size: 4 KB
> >    Transferred:
> >      Total: 130825923 KB
> >      Precopied: 15 KB
> >      Postcopied: 13691151 KB
> >      Multifd: 117134260 KB
> >    Remaining: 0 KB
> >    Total RAM: 16777992 KB
> > Page Statistics:
> >    Normal Pages: 32622225
> >    Zero Pages: 0
> >    Duplicate Pages: 997263
> >    Transfer Page Rate: 169431
> >    Dirty Page Rate: 1234
> >    Dirty Syncs: 10
> 
> I would trust you more than the AI, so feel free to share your opinion next
> time (which won't hurt if it was a result of AI discussions, but only which
> you agreed on :).

Haha, yes; whatever it is for those humans find easiest - that's the H in HMP!
(Those AIs can parse Json way easier than I can read Json!)

Of course you don't need to reorg it all at once again, if someone finds
one section hard, then reorg the way that people find it easy.

> It's already in a pull, let's revisit whenever necessary.  Thanks for the
> input!
> 

Nod.

Dave


> -- 
> Peter Xu
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/