All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	Jason@zx2c4.com, tytso@mit.edu
Subject: Re: [PATCH 0/4] crypto: lib/chacha - improve type safety
Date: Mon, 12 May 2025 13:45:51 +0800	[thread overview]
Message-ID: <aCGLDzAkVn65P4n4@gondor.apana.org.au> (raw)
In-Reply-To: <20250505181824.647138-1-ebiggers@kernel.org>

Eric Biggers <ebiggers@kernel.org> wrote:
> This series can also be retrieved from:
> 
>    git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git chacha-prototypes-v1
> 
> This series improves type safety and clarity in the ChaCha functions by
> strongly typing the state array and adding explicit array bounds for
> other fixed-length arrays.  No functional changes.
> 
> Eric Biggers (4):
>  crypto: lib/chacha - strongly type the ChaCha state
>  crypto: lib/chacha - use struct assignment to copy state
>  crypto: lib/chacha - add strongly-typed state zeroization
>  crypto: lib/chacha - add array bounds to function prototypes
> 
> arch/arm/lib/crypto/chacha-glue.c             | 34 ++++----
> arch/arm/lib/crypto/chacha-scalar-core.S      |  5 +-
> arch/arm64/lib/crypto/chacha-neon-glue.c      | 27 ++++---
> arch/mips/lib/crypto/chacha-glue.c            |  6 +-
> arch/powerpc/lib/crypto/chacha-p10-glue.c     | 17 ++--
> arch/powerpc/lib/crypto/chacha-p10le-8x.S     |  6 +-
> arch/riscv/lib/crypto/chacha-riscv64-glue.c   |  9 ++-
> arch/riscv/lib/crypto/chacha-riscv64-zvkb.S   | 10 +--
> arch/s390/lib/crypto/chacha-glue.c            | 13 +--
> arch/x86/lib/crypto/chacha_glue.c             | 62 ++++++++------
> crypto/chacha.c                               | 20 ++---
> drivers/char/random.c                         | 41 +++++-----
> fs/bcachefs/checksum.c                        | 18 ++---
> include/crypto/chacha.h                       | 80 ++++++++++++-------
> lib/crypto/chacha.c                           | 40 +++++-----
> lib/crypto/chacha20poly1305-selftest.c        |  8 +-
> lib/crypto/chacha20poly1305.c                 | 53 ++++++------
> lib/crypto/libchacha.c                        |  2 +-
> .../crypto/chacha20-s390/test-cipher.c        | 10 +--
> 19 files changed, 253 insertions(+), 208 deletions(-)
> 
> 
> base-commit: 64745a9ca890ed60d78162ec511e1983e1946d73

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	Jason@zx2c4.com, tytso@mit.edu
Subject: Re: [PATCH 0/4] crypto: lib/chacha - improve type safety
Date: Mon, 12 May 2025 13:45:51 +0800	[thread overview]
Message-ID: <aCGLDzAkVn65P4n4@gondor.apana.org.au> (raw)
In-Reply-To: <20250505181824.647138-1-ebiggers@kernel.org>

Eric Biggers <ebiggers@kernel.org> wrote:
> This series can also be retrieved from:
> 
>    git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git chacha-prototypes-v1
> 
> This series improves type safety and clarity in the ChaCha functions by
> strongly typing the state array and adding explicit array bounds for
> other fixed-length arrays.  No functional changes.
> 
> Eric Biggers (4):
>  crypto: lib/chacha - strongly type the ChaCha state
>  crypto: lib/chacha - use struct assignment to copy state
>  crypto: lib/chacha - add strongly-typed state zeroization
>  crypto: lib/chacha - add array bounds to function prototypes
> 
> arch/arm/lib/crypto/chacha-glue.c             | 34 ++++----
> arch/arm/lib/crypto/chacha-scalar-core.S      |  5 +-
> arch/arm64/lib/crypto/chacha-neon-glue.c      | 27 ++++---
> arch/mips/lib/crypto/chacha-glue.c            |  6 +-
> arch/powerpc/lib/crypto/chacha-p10-glue.c     | 17 ++--
> arch/powerpc/lib/crypto/chacha-p10le-8x.S     |  6 +-
> arch/riscv/lib/crypto/chacha-riscv64-glue.c   |  9 ++-
> arch/riscv/lib/crypto/chacha-riscv64-zvkb.S   | 10 +--
> arch/s390/lib/crypto/chacha-glue.c            | 13 +--
> arch/x86/lib/crypto/chacha_glue.c             | 62 ++++++++------
> crypto/chacha.c                               | 20 ++---
> drivers/char/random.c                         | 41 +++++-----
> fs/bcachefs/checksum.c                        | 18 ++---
> include/crypto/chacha.h                       | 80 ++++++++++++-------
> lib/crypto/chacha.c                           | 40 +++++-----
> lib/crypto/chacha20poly1305-selftest.c        |  8 +-
> lib/crypto/chacha20poly1305.c                 | 53 ++++++------
> lib/crypto/libchacha.c                        |  2 +-
> .../crypto/chacha20-s390/test-cipher.c        | 10 +--
> 19 files changed, 253 insertions(+), 208 deletions(-)
> 
> 
> base-commit: 64745a9ca890ed60d78162ec511e1983e1946d73

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-05-12  5:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 18:18 [PATCH 0/4] crypto: lib/chacha - improve type safety Eric Biggers
2025-05-05 18:18 ` Eric Biggers
2025-05-05 18:18 ` [PATCH 1/4] crypto: lib/chacha - strongly type the ChaCha state Eric Biggers
2025-05-05 18:18   ` Eric Biggers
2025-05-06 16:09   ` Kent Overstreet
2025-05-06 16:09     ` Kent Overstreet
2025-05-05 18:18 ` [PATCH 2/4] crypto: lib/chacha - use struct assignment to copy state Eric Biggers
2025-05-05 18:18   ` Eric Biggers
2025-05-05 18:18 ` [PATCH 3/4] crypto: lib/chacha - add strongly-typed state zeroization Eric Biggers
2025-05-05 18:18   ` Eric Biggers
2025-05-05 18:18 ` [PATCH 4/4] crypto: lib/chacha - add array bounds to function prototypes Eric Biggers
2025-05-05 18:18   ` Eric Biggers
2025-05-12  5:45 ` Herbert Xu [this message]
2025-05-12  5:45   ` [PATCH 0/4] crypto: lib/chacha - improve type safety Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCGLDzAkVn65P4n4@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=Jason@zx2c4.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bcachefs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.