From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read()
Date: Mon, 12 May 2025 15:27:08 +0000 [thread overview]
Message-ID: <aCITTEkOYqZdYTy1@google.com> (raw)
In-Reply-To: <20250512115442.2640895-2-chao@kernel.org>
On 05/12, Chao Yu wrote:
> mapping_read_folio_gfp() will return a folio, it should always be
> uptodate, let's check folio uptodate status to detect any potenial
> bug.
If it's supposed to be uptodate, can you add f2fs_bug_on() only?
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/super.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0ee783224953..ea207a9edc10 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2973,6 +2973,17 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
> goto repeat;
> }
>
> + /*
> + * should never happen, just leave f2fs_bug_on() here to catch
> + * any potential bug.
> + */
> + if (unlikely(!folio_test_uptodate(folio))) {
> + f2fs_folio_put(folio, true);
> + set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR);
> + f2fs_bug_on(F2FS_SB(sb), 1);
> + return -EIO;
> + }
> +
> memcpy_from_folio(data, folio, offset, tocopy);
> f2fs_folio_put(folio, true);
>
> --
> 2.49.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read()
Date: Mon, 12 May 2025 15:27:08 +0000 [thread overview]
Message-ID: <aCITTEkOYqZdYTy1@google.com> (raw)
In-Reply-To: <20250512115442.2640895-2-chao@kernel.org>
On 05/12, Chao Yu wrote:
> mapping_read_folio_gfp() will return a folio, it should always be
> uptodate, let's check folio uptodate status to detect any potenial
> bug.
If it's supposed to be uptodate, can you add f2fs_bug_on() only?
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/super.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0ee783224953..ea207a9edc10 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2973,6 +2973,17 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
> goto repeat;
> }
>
> + /*
> + * should never happen, just leave f2fs_bug_on() here to catch
> + * any potential bug.
> + */
> + if (unlikely(!folio_test_uptodate(folio))) {
> + f2fs_folio_put(folio, true);
> + set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR);
> + f2fs_bug_on(F2FS_SB(sb), 1);
> + return -EIO;
> + }
> +
> memcpy_from_folio(data, folio, offset, tocopy);
> f2fs_folio_put(folio, true);
>
> --
> 2.49.0
next prev parent reply other threads:[~2025-05-12 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 11:54 [f2fs-dev] [PATCH 1/2] f2fs: add f2fs_bug_on() to detect potential bug Chao Yu via Linux-f2fs-devel
2025-05-12 11:54 ` Chao Yu
2025-05-12 11:54 ` [f2fs-dev] [PATCH 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read() Chao Yu via Linux-f2fs-devel
2025-05-12 11:54 ` Chao Yu
2025-05-12 15:27 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-05-12 15:27 ` Jaegeuk Kim
2025-05-13 2:45 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-13 2:45 ` Chao Yu
2025-05-12 15:26 ` [f2fs-dev] [PATCH 1/2] f2fs: add f2fs_bug_on() to detect potential bug Jaegeuk Kim via Linux-f2fs-devel
2025-05-12 15:26 ` Jaegeuk Kim
2025-05-13 2:44 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-13 2:44 ` Chao Yu
2025-05-14 15:40 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-05-14 15:40 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCITTEkOYqZdYTy1@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.