From: Niklas Cassel <cassel@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
heiko@sntech.de, manivannan.sadhasivam@linaro.org,
yue.wang@amlogic.com, pali@kernel.org, neil.armstrong@linaro.org,
robh@kernel.org, jingoohan1@gmail.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 2/2] PCI: dwc: Remove redundant MPS configuration
Date: Tue, 13 May 2025 10:05:30 +0200 [thread overview]
Message-ID: <aCL9Stg0UKJ2AfDK@ryzen> (raw)
In-Reply-To: <20250510155607.390687-3-18255117159@163.com>
On Sat, May 10, 2025 at 11:56:07PM +0800, Hans Zhang wrote:
> The Meson PCIe controller driver manually configures maximum payload
> size (MPS) through meson_set_max_payload, duplicating functionality now
> centralized in the PCI core. Deprecating redundant code simplifies the
> driver and aligns it with the consolidated MPS management strategy,
> improving long-term maintainability.
>
> Signed-off-by: Hans Zhang <18255117159@163.com>
> ---
Looks good to me:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <cassel@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
heiko@sntech.de, manivannan.sadhasivam@linaro.org,
yue.wang@amlogic.com, pali@kernel.org, neil.armstrong@linaro.org,
robh@kernel.org, jingoohan1@gmail.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 2/2] PCI: dwc: Remove redundant MPS configuration
Date: Tue, 13 May 2025 10:05:30 +0200 [thread overview]
Message-ID: <aCL9Stg0UKJ2AfDK@ryzen> (raw)
In-Reply-To: <20250510155607.390687-3-18255117159@163.com>
On Sat, May 10, 2025 at 11:56:07PM +0800, Hans Zhang wrote:
> The Meson PCIe controller driver manually configures maximum payload
> size (MPS) through meson_set_max_payload, duplicating functionality now
> centralized in the PCI core. Deprecating redundant code simplifies the
> driver and aligns it with the consolidated MPS management strategy,
> improving long-term maintainability.
>
> Signed-off-by: Hans Zhang <18255117159@163.com>
> ---
Looks good to me:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <cassel@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
heiko@sntech.de, manivannan.sadhasivam@linaro.org,
yue.wang@amlogic.com, pali@kernel.org, neil.armstrong@linaro.org,
robh@kernel.org, jingoohan1@gmail.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 2/2] PCI: dwc: Remove redundant MPS configuration
Date: Tue, 13 May 2025 10:05:30 +0200 [thread overview]
Message-ID: <aCL9Stg0UKJ2AfDK@ryzen> (raw)
In-Reply-To: <20250510155607.390687-3-18255117159@163.com>
On Sat, May 10, 2025 at 11:56:07PM +0800, Hans Zhang wrote:
> The Meson PCIe controller driver manually configures maximum payload
> size (MPS) through meson_set_max_payload, duplicating functionality now
> centralized in the PCI core. Deprecating redundant code simplifies the
> driver and aligns it with the consolidated MPS management strategy,
> improving long-term maintainability.
>
> Signed-off-by: Hans Zhang <18255117159@163.com>
> ---
Looks good to me:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-05-13 8:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 15:56 [PATCH v4 0/2] Configure root port MPS during host probing Hans Zhang
2025-05-10 15:56 ` Hans Zhang
2025-05-10 15:56 ` Hans Zhang
2025-05-10 15:56 ` [PATCH v4 1/2] PCI: " Hans Zhang
2025-05-10 15:56 ` Hans Zhang
2025-05-10 15:56 ` Hans Zhang
2025-05-13 8:04 ` Niklas Cassel
2025-05-13 8:04 ` Niklas Cassel
2025-05-13 8:04 ` Niklas Cassel
2025-05-13 14:53 ` Hans Zhang
2025-05-13 14:53 ` Hans Zhang
2025-05-13 14:53 ` Hans Zhang
2025-06-13 6:38 ` Manivannan Sadhasivam
2025-06-13 6:38 ` Manivannan Sadhasivam
2025-06-13 6:38 ` Manivannan Sadhasivam
2025-06-13 11:52 ` Niklas Cassel
2025-06-13 11:52 ` Niklas Cassel
2025-06-13 11:52 ` Niklas Cassel
2025-06-13 15:31 ` Hans Zhang
2025-06-13 15:31 ` Hans Zhang
2025-06-13 15:31 ` Hans Zhang
2025-06-19 12:45 ` Manivannan Sadhasivam
2025-06-19 12:45 ` Manivannan Sadhasivam
2025-06-19 12:45 ` Manivannan Sadhasivam
2025-05-10 15:56 ` [PATCH v4 2/2] PCI: dwc: Remove redundant MPS configuration Hans Zhang
2025-05-10 15:56 ` Hans Zhang
2025-05-10 15:56 ` Hans Zhang
2025-05-13 8:05 ` Niklas Cassel [this message]
2025-05-13 8:05 ` Niklas Cassel
2025-05-13 8:05 ` Niklas Cassel
2025-06-13 6:54 ` Manivannan Sadhasivam
2025-06-13 6:54 ` Manivannan Sadhasivam
2025-06-13 6:54 ` Manivannan Sadhasivam
2025-06-13 15:40 ` Hans Zhang
2025-06-13 15:40 ` Hans Zhang
2025-06-13 15:40 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCL9Stg0UKJ2AfDK@ryzen \
--to=cassel@kernel.org \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jingoohan1@gmail.com \
--cc=khilman@baylibre.com \
--cc=kw@linux.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.