Re: [PATCH 02/10] riscv: dts: th1520: Add clock-frequency for UART0

[Yao Zi <ziyao@disroot.org>]

On Mon, May 12, 2025 at 07:53:01AM -0400, e wrote:
> On 2025-05-12 05:57, Leo Liang wrote:
> > On Sat, Apr 26, 2025 at 04:56:56PM +0000, Yao Zi wrote:
> > > [EXTERNAL MAIL]
> > > 
> > > The BROM of TH1520 always initializes its clock and configure the
> > > baudrate to 115200. Add a clock-frequency property to provide such
> > > information without introducing CCF to SPL.
> > > 
> > > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > > ---
> > >  arch/riscv/dts/th1520.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
> 
> NAK from me. Quoting Emil "The uart0 node already has a reference to the
> uart0_core clock, so it shouldn't
> need this property." If SPL does not support the clock framework to do this
> parent node lookup properly from device-tree then we should not be adjusting
> the device-tree in this way; use instead the codepath in serial driver that
> checks a compile-time define.

I was not aware of the codepath, thanks for the hint! It should be the
correct way to go and I'll try to take in v2.

> See for example:
> https://lore.kernel.org/u-boot/20250503115301.972550-1-e@freeshell.de/
> 
> - E

Best regards,
Yao Zi