From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Shaun Brady <brady.1345@gmail.com>,
netfilter-devel@vger.kernel.org, ppwaskie@kernel.org
Subject: Re: [PATCH v3] netfilter: nf_tables: Implement jump limit for nft_table_validate
Date: Wed, 14 May 2025 14:16:09 +0200 [thread overview]
Message-ID: <aCSJiV5Hz-MTMFLd@strlen.de> (raw)
In-Reply-To: <aCRPkxvH5LCtc7Bi@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Mon, May 12, 2025 at 10:08:56PM -0400, Shaun Brady wrote:
> [...]
> > Add a new counter, total_jump_counter, to nft_ctx. On every call to
> > nft_table_validate() (rule addition time, versus packet inspection time)
> > start the counter at the current sum of all jump counts in all other
> > tables with the same family, as well as netdev.
>
> What about the bridge family? If bridged frames are passed up to the
> IP stack, then these hooks can have basechains with jumps too.
Good point, I forgot about this.
> Maybe it is better to have a global limit for all tables, regardless
> the family, in a non-init-netns?
Looks like it would be simpler.
The only cases where processing is disjunct is ipv4 vs. ipv6.
And arp. But large arp rulesets are unicorns so we should not bother
with that.
next prev parent reply other threads:[~2025-05-14 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 2:08 [PATCH v3] netfilter: nf_tables: Implement jump limit for nft_table_validate Shaun Brady
2025-05-14 8:19 ` Pablo Neira Ayuso
2025-05-14 12:16 ` Florian Westphal [this message]
2025-05-15 1:09 ` Shaun Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCSJiV5Hz-MTMFLd@strlen.de \
--to=fw@strlen.de \
--cc=brady.1345@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ppwaskie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.