From: Shaun Brady <brady.1345@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, ppwaskie@kernel.org
Subject: Re: [PATCH v3] netfilter: nf_tables: Implement jump limit for nft_table_validate
Date: Wed, 14 May 2025 21:09:27 -0400 [thread overview]
Message-ID: <aCU-x4SbsJ_Jy7RM@fedora> (raw)
In-Reply-To: <aCSJiV5Hz-MTMFLd@strlen.de>
On Wed, May 14, 2025 at 02:16:09PM +0200, Florian Westphal wrote:
> > Maybe it is better to have a global limit for all tables, regardless
> > the family, in a non-init-netns?
>
> Looks like it would be simpler.
>
> The only cases where processing is disjunct is ipv4 vs. ipv6.
>
> And arp. But large arp rulesets are unicorns so we should not bother
> with that.
I'm good with the simpler condition. Let me double check my
understanding:
Each table will keep a running jump count. When validating a table
(rule modification), sum every other table in the netns, with the single condition set being
if sibling_table->family == NFPROTO_IPV4 && table->family == NFPROTO_IPV6
||
sibling_table->family == NFPROTO_IPV6 && table->family == NFPROTO_IPV4
do not include in total for netns (break).
Assuming this logic is sound, I'll do v4.
Thanks!
SB
prev parent reply other threads:[~2025-05-15 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 2:08 [PATCH v3] netfilter: nf_tables: Implement jump limit for nft_table_validate Shaun Brady
2025-05-14 8:19 ` Pablo Neira Ayuso
2025-05-14 12:16 ` Florian Westphal
2025-05-15 1:09 ` Shaun Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCU-x4SbsJ_Jy7RM@fedora \
--to=brady.1345@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ppwaskie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.