Re: [PATCH 11/11] iotests/graph-changes-while-io: add test case with removal of lower snapshot

[Kevin Wolf <kwolf@redhat.com>]

Am 08.05.2025 um 16:09 hat Fiona Ebner geschrieben:
> From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> 
> This case is catching potential deadlock which takes place when job-dismiss
> is issued when I/O requests are processed in a separate iothread.
> 
> See https://mail.gnu.org/archive/html/qemu-devel/2025-04/msg04421.html
> 
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>

Keeping Andrey in From: is fine, but it does need your S-o-b if you
submit the patch.

> diff --git a/tests/qemu-iotests/tests/graph-changes-while-io b/tests/qemu-iotests/tests/graph-changes-while-io
> index 194fda500e..e30f823da4 100755
> --- a/tests/qemu-iotests/tests/graph-changes-while-io
> +++ b/tests/qemu-iotests/tests/graph-changes-while-io
> @@ -27,6 +27,8 @@ from iotests import imgfmt, qemu_img, qemu_img_create, qemu_io, \
>  
>  
>  top = os.path.join(iotests.test_dir, 'top.img')
> +snap1 = os.path.join(iotests.test_dir, 'snap1.img')
> +snap2 = os.path.join(iotests.test_dir, 'snap2.img')
>  nbd_sock = os.path.join(iotests.sock_dir, 'nbd.sock')

top could be reused for snap2, it serves the same purpose in the
existing tests. Maybe mid for snap1 would make more sense then.

The only other problem I can see is that the test forgets to remove the
overlay image files (preexisting for top).

It did reproduce the problem on the first attempt, though, so:
Tested-by: Kevin Wolf <kwolf@redhat.com>