Re: [PATCH 04/11] block: drain while unlocked in bdrv_reopen_parse_file_or_backing()

[Kevin Wolf <kwolf@redhat.com>]

Am 08.05.2025 um 16:09 hat Fiona Ebner geschrieben:
> This is in preparation to mark bdrv_drained_begin() as GRAPH_UNLOCKED.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  block.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/block.c b/block.c
> index 0085dbfa74..c7c26533c9 100644
> --- a/block.c
> +++ b/block.c
> @@ -4805,10 +4805,11 @@ bdrv_reopen_parse_file_or_backing(BDRVReopenState *reopen_state,
>  
>      if (old_child_bs) {
>          bdrv_ref(old_child_bs);
> +        bdrv_graph_rdunlock_main_loop();
>          bdrv_drained_begin(old_child_bs);
> +    } else {
> +        bdrv_graph_rdunlock_main_loop();
>      }

This pattern is a bit ugly, so good that you get rid of it again later
in the series.

> -
> -    bdrv_graph_rdunlock_main_loop();
>      bdrv_graph_wrlock();
>  
>      ret = bdrv_set_file_or_backing_noperm(bs, new_child_bs, is_backing,

Reviewed-by: Kevin Wolf <kwolf@redhat.com>