Re: [PATCH 4/7] PCI: Remove request_flags relict from devres

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, May 15, 2025 at 02:46:02PM +0200, Philipp Stanner wrote:
> pcim_request_region_exclusive(), the only user in PCI devres that needed
> exclusive region requests, has been removed.
> 
> All features related to exclusive requests can, therefore, be removed,
> too. Remove them.

...

>  int pcim_request_region(struct pci_dev *pdev, int bar, const char *name)
>  {
> -	return _pcim_request_region(pdev, bar, name, 0);
> +	int ret;
> +	struct pcim_addr_devres *res;
> +
> +	if (!pci_bar_index_is_valid(bar))
> +		return -EINVAL;
> +
> +	res = pcim_addr_devres_alloc(pdev);
> +	if (!res)
> +		return -ENOMEM;
> +	res->type = PCIM_ADDR_DEVRES_TYPE_REGION;
> +	res->bar = bar;
> +
> +	ret = __pcim_request_region(pdev, bar, name, 0);

> +	if (ret != 0) {

While at it, drop the  ' != 0' part?

> +		pcim_addr_devres_free(res);
> +		return ret;
> +	}
> +
> +	devres_add(&pdev->dev, res);
> +	return 0;
>  }

-- 
With Best Regards,
Andy Shevchenko