From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: phasta@kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Zijun Hu <quic_zijuhu@quicinc.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 6/7] PCI: Remove unnecessary prototype from pci.h
Date: Fri, 16 May 2025 12:16:45 +0300 [thread overview]
Message-ID: <aCcCfeRqqOqWKG63@smile.fi.intel.com> (raw)
In-Reply-To: <3f1140397e628cfdf4156f02f5454f844003dc6d.camel@mailbox.org>
On Thu, May 15, 2025 at 03:37:06PM +0200, Philipp Stanner wrote:
> On Thu, 2025-05-15 at 16:02 +0300, Andy Shevchenko wrote:
> > On Thu, May 15, 2025 at 02:46:04PM +0200, Philipp Stanner wrote:
> > > pcim_intx() once was an internal PCI function, but since then has
> > > been
> > > published and is used by drivers, and, therefore, available in
> > > include/linux/pci.h. The function is not used within PCI anymore.
> > >
> > > Remove pcim_intx()'s prototype from drivers/pci/pci.h
> >
> > Can this be moved up in the series? Or is there other dependencies?
> > I.o.w. this
> > looks like a leftover from something of the previous work.
>
> That can be moved to anywhere, including a separate patch. It's an
> independent patch, a leftover from last year. But it's related to
> devres, because it was also added because of the problem with
> pcim_enable_device().
When put at the end of the series it makes an illusion that there are
dependencies. Separate patch is ideal, being first is good enough to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-16 9:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:45 [PATCH 0/7] PCI: Remove hybrid-devres region requests Philipp Stanner
2025-05-15 12:45 ` [PATCH 1/7] PCI: Remove hybrid devres nature from request functions Philipp Stanner
2025-05-15 12:46 ` [PATCH 2/7] Docu: PCI: Update pcim_enable_device() Philipp Stanner
2025-05-15 12:58 ` Andy Shevchenko
2025-05-16 7:49 ` Philipp Stanner
2025-05-16 13:28 ` Krzysztof Wilczyński
2025-05-16 13:41 ` Philipp Stanner
2025-05-16 13:48 ` Krzysztof Wilczyński
2025-05-17 16:32 ` Andy Shevchenko
2025-05-15 12:46 ` [PATCH 3/7] PCI: Remove pcim_request_region_exclusive() Philipp Stanner
2025-05-15 12:46 ` [PATCH 4/7] PCI: Remove request_flags relict from devres Philipp Stanner
2025-05-15 13:00 ` Andy Shevchenko
2025-05-16 7:48 ` Philipp Stanner
2025-05-15 12:46 ` [PATCH 5/7] PCI: Remove redundant set of request funcs Philipp Stanner
2025-05-15 12:46 ` [PATCH 6/7] PCI: Remove unnecessary prototype from pci.h Philipp Stanner
2025-05-15 13:02 ` Andy Shevchenko
2025-05-15 13:37 ` Philipp Stanner
2025-05-16 9:16 ` Andy Shevchenko [this message]
2025-05-15 12:46 ` [PATCH 7/7] PCI: Remove hybrid-devres hazzard warnings from doc Philipp Stanner
2025-05-15 13:08 ` [PATCH 0/7] PCI: Remove hybrid-devres region requests Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCcCfeRqqOqWKG63@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.