[meta-virtualization][PATCH] libvirt: fix compile failure while DEBUG_BUILD = 1

[meta-virtualization][PATCH] libvirt: fix compile failure while DEBUG_BUILD = 1

[Hongxu Jia]

Build libvirt failed while DEBUG_BUILD = 1
[snip]
../git/src/cpu/cpu_x86.c: In function 'cpuidSetLeaf4':
../git/src/cpu/cpu_x86.c:2563:1: error: inlining failed in call to 'cpuidCall': function not considered for inlining [-Werror=inline]
 2563 | cpuidCall(virCPUx86CPUID *cpuid)
      | ^~~~~~~~~
[snip]

Explicitly add -Wno-error=inline to CFLAGS if DEBUG_BUILD = 1 to workaround

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 recipes-extended/libvirt/libvirt_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-extended/libvirt/libvirt_git.bb b/recipes-extended/libvirt/libvirt_git.bb
index 4c6b3bdd..37a60562 100644
--- a/recipes-extended/libvirt/libvirt_git.bb
+++ b/recipes-extended/libvirt/libvirt_git.bb
@@ -50,6 +50,7 @@ USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM:${PN} = "-r qemu; -r kvm"
 USERADD_PARAM:${PN} = "-r -g qemu -G kvm qemu"
 
+CFLAGS += "${@oe.utils.vartrue('DEBUG_BUILD', '-Wno-error=inline', '', d)}"
 
 EXTRA_OEMESON += "--cross-file ${WORKDIR}/meson-${PN}.cross"
 do_write_config:append() {
-- 
2.34.1

Re: [meta-virtualization][PATCH] libvirt: fix compile failure while DEBUG_BUILD = 1

[Fabio Estevam]

Hi Hongxu,

On Wednesday, May 14, 2025 04:59 -03, "hongxu via lists.yoctoproject.org" <hongxu.jia=eng.windriver.com@lists.yoctoproject.org> wrote:

> Build libvirt failed while DEBUG_BUILD = 1
> [snip]
> ../git/src/cpu/cpu_x86.c: In function 'cpuidSetLeaf4':
> ../git/src/cpu/cpu_x86.c:2563:1: error: inlining failed in call to 'cpuidCall': function not considered for inlining [-Werror=inline]
>  2563 | cpuidCall(virCPUx86CPUID *cpuid)
>       | ^~~~~~~~~
> [snip]
> 
> Explicitly add -Wno-error=inline to CFLAGS if DEBUG_BUILD = 1 to workaround

I have sent a fix upstream:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/AB7ZAE2BCMG7CXIJHOHD3MNLBCSCOOBK/

Re: [meta-virtualization][PATCH] libvirt: fix compile failure while DEBUG_BUILD ?utf-8?q?_=3D?= 1

[Bruce Ashfield]

In message: Re: [meta-virtualization][PATCH] libvirt: fix compile failure while DEBUG_BUILD ?utf-8?q?_=3D?= 1
on 16/05/2025 Fabio Estevam via lists.yoctoproject.org wrote:

> Hi Hongxu,
> 
> On Wednesday, May 14, 2025 04:59 -03, "hongxu via lists.yoctoproject.org" <hongxu.jia=eng.windriver.com@lists.yoctoproject.org> wrote:
> 
> > Build libvirt failed while DEBUG_BUILD = 1
> > [snip]
> > ../git/src/cpu/cpu_x86.c: In function 'cpuidSetLeaf4':
> > ../git/src/cpu/cpu_x86.c:2563:1: error: inlining failed in call to 'cpuidCall': function not considered for inlining [-Werror=inline]
> >  2563 | cpuidCall(virCPUx86CPUID *cpuid)
> >       | ^~~~~~~~~
> > [snip]
> > 
> > Explicitly add -Wno-error=inline to CFLAGS if DEBUG_BUILD = 1 to workaround
> 
> I have sent a fix upstream:
> 
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/AB7ZAE2BCMG7CXIJHOHD3MNLBCSCOOBK/
> 

I don't see any replies to the patch, but I'll be updating libvirt in the next
couple of weeks, so I'll check to see if anything merged then.

In the meantime, I've merged the original patch.

Bruce

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9249): https://lists.yoctoproject.org/g/meta-virtualization/message/9249
> Mute This Topic: https://lists.yoctoproject.org/mt/113143907/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [meta-virtualization][PATCH] libvirt: fix compile failure while DEBUG_BUILD ?utf-8?q?_=3D?= 1

[Fabio Estevam]

Hi Bruce,

On Monday, May 19, 2025 23:57 -03, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
 
> I don't see any replies to the patch, but I'll be updating libvirt in the next
> couple of weeks, so I'll check to see if anything merged then.
> 
> In the meantime, I've merged the original patch.

The patch I sent has been applied to libvirt master:

https://gitlab.com/libvirt/libvirt/-/commit/bf79a021a6437b4f85469a53f650bff62db5f674