Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version

[Johan Hovold <johan@kernel.org>]

On Tue, May 20, 2025 at 10:02:32AM +0200, Krzysztof Kozlowski wrote:
> On 20/05/2025 09:53, Johan Hovold wrote:

> > Spamming the logs as the driver currently does is clearly broken and
> > should be fixed. Keeping a hw version dev_dbg() is generally perfectly
> > fine, though.

> My main argument, expressed in the commit msg to which no one objected,
> is that this debug is 100% useless: deducible from the compatible,
> always known upfront, always the same.

To me that deduction does not seem straightforward, at least not without
access to internal qualcomm docs, for example:

	compatible = "qcom,sc8280xp-camss";

        qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2
	qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2
        qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
        qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2
        qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0
        qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
        qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
        qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0

Whether the hw version is actually useful to anyone debugging this
driver I can't say, but keeping it printed *once* seems perfectly
alright if someone wants to keep it (e.g. as we have a long history of
working around hw bugs based on revision information like this).

Johan