From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version
Date: Tue, 20 May 2025 11:17:10 +0200 [thread overview]
Message-ID: <aCxIlnPsVZBiUpc8@hovoldconsulting.com> (raw)
In-Reply-To: <d81de587-7452-4fa1-836e-9e30b6d63c57@linaro.org>
On Tue, May 20, 2025 at 10:51:56AM +0200, Krzysztof Kozlowski wrote:
> On 20/05/2025 10:44, Bryan O'Donoghue wrote:
> > I find the debug prints useful in that I know the hardware block has
> > been powered on, clocked etc. I agree the number of those prints seems
> > excessive.
> >
> > The reason it is printed out multiple time is the blocks get powered on/off.
> >
> > Personally I agree with Johan - it would be nice/useful to print it out
> > once with DEBUG on, so that we know we have successfully powered-on and
>
> That's opposite to what coding style asks. Success should be silent.
The coding style says probe should be silent, but debug statements are
not printed by default so that bit does not apply here.
Johan
next prev parent reply other threads:[~2025-05-20 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 18:08 [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version Krzysztof Kozlowski
2025-04-29 18:08 ` [PATCH 2/3] media: qcom: camss: csid: " Krzysztof Kozlowski
2025-04-29 18:08 ` [PATCH 3/3] media: qcom: camss: csiphy: " Krzysztof Kozlowski
2025-04-29 18:11 ` [PATCH 1/3] media: qcom: camss: vfe: " Krzysztof Kozlowski
2025-04-29 19:40 ` Bryan O'Donoghue
2025-04-30 6:15 ` Krzysztof Kozlowski
2025-04-30 7:25 ` Johan Hovold
2025-04-30 8:19 ` Krzysztof Kozlowski
2025-04-30 8:30 ` Bryan O'Donoghue
2025-04-30 8:33 ` Krzysztof Kozlowski
2025-05-20 6:06 ` Krzysztof Kozlowski
2025-05-20 7:53 ` Johan Hovold
2025-05-20 8:02 ` Krzysztof Kozlowski
2025-05-20 8:23 ` Johan Hovold
2025-05-20 8:30 ` Krzysztof Kozlowski
2025-05-20 8:39 ` Johan Hovold
2025-05-20 8:44 ` Bryan O'Donoghue
2025-05-20 8:51 ` Krzysztof Kozlowski
2025-05-20 8:58 ` Bryan O'Donoghue
2025-05-20 9:16 ` Krzysztof Kozlowski
2025-05-20 9:17 ` Johan Hovold [this message]
2025-04-30 12:31 ` Johan Hovold
2025-04-30 8:24 ` Bryan O'Donoghue
2025-04-30 12:34 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCxIlnPsVZBiUpc8@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.