All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Ilya K <me@0upti.me>
Cc: Eric Woudstra <ericwouds@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Frank Wunderlich <frank-w@public-files.de>,
	Daniel Golle <daniel@makrotopia.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH RFC net-next] net: phylink: always config mac for (delayed) phy
Date: Mon, 2 Jun 2025 09:48:06 +0100	[thread overview]
Message-ID: <aD1lRha-enQ9Pw0g@shell.armlinux.org.uk> (raw)
In-Reply-To: <9cc913d7-7e5b-4b6c-886c-ca9778c3f970@0upti.me>

On Mon, Jun 02, 2025 at 10:19:22AM +0300, Ilya K wrote:
> On 2025-01-09 12:15, Russell King (Oracle) wrote:
> > On Thu, Jan 09, 2025 at 09:56:17AM +0100, Eric Woudstra wrote:
> > I'll look at what we can do for this today.
> Hey folks, don't really want to necrobump this, but the original hack patch is the only way I can get my weirdo Realtek (noticing a pattern here) GPON modem-on-a-stick to probe at 2500base-x on a BPi-R4. I've actually tracked down the issue myself and wrote basically the same patch first :( Is there anything I can do (with my extremely limited phylink understanding) to help move this forward so other people don't have to suffer like I did?

There were two issues that were identified. The first was that when in
2500Base-X mode, the PCS wasn't reporting link-up. That was addressed
by the patch series:

Z4TbR93B-X8A8iHe@shell.armlinux.org.uk

then, the replacement for Eric's patch was:

E1tYhxp-001FHf-Ac@rmk-PC.armlinux.org.uk

So the problem should be solved with these applied, as when the PHY is
attached, "changed" will always be true, which is in effect what Eric's
patch was doing, but in a cleaner way.

Please confirm that you have all six patches applied.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Ilya K <me@0upti.me>
Cc: Andrew Lunn <andrew@lunn.ch>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Daniel Golle <daniel@makrotopia.org>,
	bridge@lists.linux.dev, linux-kernel@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
	Eric Woudstra <ericwouds@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH RFC net-next] net: phylink: always config mac for (delayed) phy
Date: Mon, 2 Jun 2025 09:48:06 +0100	[thread overview]
Message-ID: <aD1lRha-enQ9Pw0g@shell.armlinux.org.uk> (raw)
In-Reply-To: <9cc913d7-7e5b-4b6c-886c-ca9778c3f970@0upti.me>

On Mon, Jun 02, 2025 at 10:19:22AM +0300, Ilya K wrote:
> On 2025-01-09 12:15, Russell King (Oracle) wrote:
> > On Thu, Jan 09, 2025 at 09:56:17AM +0100, Eric Woudstra wrote:
> > I'll look at what we can do for this today.
> Hey folks, don't really want to necrobump this, but the original hack patch is the only way I can get my weirdo Realtek (noticing a pattern here) GPON modem-on-a-stick to probe at 2500base-x on a BPi-R4. I've actually tracked down the issue myself and wrote basically the same patch first :( Is there anything I can do (with my extremely limited phylink understanding) to help move this forward so other people don't have to suffer like I did?

There were two issues that were identified. The first was that when in
2500Base-X mode, the PCS wasn't reporting link-up. That was addressed
by the patch series:

Z4TbR93B-X8A8iHe@shell.armlinux.org.uk

then, the replacement for Eric's patch was:

E1tYhxp-001FHf-Ac@rmk-PC.armlinux.org.uk

So the problem should be solved with these applied, as when the PHY is
attached, "changed" will always be true, which is in effect what Eric's
patch was doing, but in a cleaner way.

Please confirm that you have all six patches applied.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!


  reply	other threads:[~2025-06-02  8:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07 12:36 [PATCH RFC net-next] net: phylink: always config mac for (delayed) phy Eric Woudstra
2025-01-07 12:47 ` Russell King (Oracle)
2025-01-07 12:47   ` Russell King (Oracle)
2025-01-07 13:14   ` Eric Woudstra
2025-01-07 13:14     ` Eric Woudstra
2025-01-07 13:20     ` Andrew Lunn
2025-01-07 13:20       ` Andrew Lunn
2025-01-07 14:23       ` Eric Woudstra
2025-01-07 14:23         ` Eric Woudstra
2025-01-07 15:03     ` Russell King (Oracle)
2025-01-07 15:03       ` Russell King (Oracle)
2025-01-09  8:56       ` Eric Woudstra
2025-01-09  8:56         ` Eric Woudstra
2025-01-09  9:15         ` Russell King (Oracle)
2025-01-09  9:15           ` Russell King (Oracle)
2025-06-02  7:19           ` Ilya K
2025-06-02  7:19             ` Ilya K
2025-06-02  8:48             ` Russell King (Oracle) [this message]
2025-06-02  8:48               ` Russell King (Oracle)
2025-06-02 13:00               ` Ilya K
2025-06-02 13:00                 ` Ilya K
2025-06-02 15:25                 ` Russell King (Oracle)
2025-06-02 15:25                   ` Russell King (Oracle)
2025-06-03 18:17                   ` Ilya K
2025-06-03 18:17                     ` Ilya K
2025-01-07 13:16   ` Daniel Golle
2025-01-07 13:16     ` Daniel Golle
2025-01-07 13:26     ` Andrew Lunn
2025-01-07 13:26       ` Andrew Lunn
2025-01-07 14:59     ` Russell King (Oracle)
2025-01-07 14:59       ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aD1lRha-enQ9Pw0g@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bridge@lists.linux.dev \
    --cc=coreteam@netfilter.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ericwouds@gmail.com \
    --cc=frank-w@public-files.de \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=me@0upti.me \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.